471921 - use proper CSS instead of first-tab, last-tab and afterselected attributes

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

We can use :first-of-type for [first-tab], :last-of-type for [last-tab] and [selected] + tab for [afterselected]. These CSS features weren't implemented or didn't even exist when the tab widgets were implemented.

Unfortunately we can't get rid of beforeselected (yet?), which leaves some complexity in tabbox.xml and tabbrowser.xml.

Comment 1

[Markus Stange [:mstange]]

Comment on attachment 355169 [details] [diff] [review]
patch

>diff --git a/widget/src/xpwidgets/nsWidgetAtomList.h b/widget/src/xpwidgets/nsWidgetAtomList.h

>-WIDGET_ATOM(firsttab, "first-tab")

>-WIDGET_ATOM(lasttab, "last-tab")

Oh, thanks for noticing that.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

updated to trunk

Comment 3

[Dão Gottwald [:dao]]

Attachment: stop using the attributes (checked in)

we should get this into 1.9.1 so that theme authors don't copy that stuff anymore

Comment 4

[Dão Gottwald [:dao]]

Attachment: stop setting the attributes

this can land later (moz2?)

Comment 5

[Dão Gottwald [:dao]]

Attachment: screenshot of rtl styling bug

this illustrates an rtl styling bug that attachment 355943 [details] [diff] [review] fixes

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 355943 [details] [diff] [review]
stop using the attributes (checked in)

http://hg.mozilla.org/mozilla-central/rev/7e5854c047bd

Comment 7

[Dave Townsend [:mossop]]

(In reply to comment #3)
> Created an attachment (id=355943) [details]
> stop using the attributes
> 
> we should get this into 1.9.1 so that theme authors don't copy that stuff
> anymore

This patch still has potential impact on theme and extension developers since it changes the behaviour of the selected attribute. If it lands on 1.9.1 it should do so before b3

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #7)
> (In reply to comment #3)
> > Created an attachment (id=355943) [details] [details]
> > stop using the attributes
> > 
> > we should get this into 1.9.1 so that theme authors don't copy that stuff
> > anymore
> 
> This patch still has potential impact on theme and extension developers since
> it changes the behaviour of the selected attribute. If it lands on 1.9.1 it
> should do so before b3

Or that change can just be left out.

Comment 9

[Dão Gottwald [:dao]]

Attachment: stop using the attributes, branch version

Comment 10

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #7)
> This patch still has potential impact on theme and extension developers since
> it changes the behaviour of the selected attribute.

I don't see any reason why anyone would care about the "false" case, so I decided I was fine with breaking it. I suppose the win isn't big enough to offset even a very-low-probability addon conflict, so I guess you're right that we should omit that change, but the idea of having to care about such a minor detail still bothers me!

Comment 11

[Dave Townsend [:mossop]]

(In reply to comment #10)
> (In reply to comment #7)
> > This patch still has potential impact on theme and extension developers since
> > it changes the behaviour of the selected attribute.
> 
> I don't see any reason why anyone would care about the "false" case, so I
> decided I was fine with breaking it. I suppose the win isn't big enough to
> offset even a very-low-probability addon conflict, so I guess you're right that
> we should omit that change, but the idea of having to care about such a minor
> detail still bothers me!

It can be used to detect whether a tab has ever been visited before. In fact I noticed it because it broke some userChrome styling I was using to achieve that very effect. I have seen extensions and themes that offer the same sort of thing and my guess is they use the attribute. I'm not against taking the change in 1.9.1, just saying that if we did so then it should be in for b3 to give themes and extensions a chance to react.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Ah, interesting. I guess the problem is really that I'm just not imaginative enough! :) Thanks for bringing it up.

Comment 13

[dickvl]

I noticed the same that my code in userChrome.css in no longer working:
/* Change color of not selected inactive tabs */
.tabbrowser-tab:not([selected]) {
 color:#c09!important; font-style:normal!important;font-size:8pt!important; font-weight:bold!important;
}

I use it a lot to open many tabs at once (forum threads) to see which are still unread if read them one by one.
The only problem was that dragging a tab left or right or using undo closed tab caused all tabs to get a selected="false" attribute.

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 355944 [details] [diff] [review]
stop setting the attributes

filed bug 480813 for this

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 356798 [details] [diff] [review]
stop using the attributes, branch version

a191=beltzner

Comment 16

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d9ad53ed0e58