471948 - [10.5] Crash [@ nsAppShell::~nsAppShell] when quitting Camino 2.0b1

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Sample Talkback reports

One-quarter of the current 2.0b1 Talkback reports are a crash in nsAppShell::~nsAppShell (identified by Talkback as this line: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/cocoa/nsAppShell.mm&mark=163&rev=CAMINO_2_0_B1_RELEASE#163), with a random system framework or library (Cocoa, CoreFoundation, SystemConfiguration, IOKit, libobjc) as the top frame.

I don't know what we can tell from this, or how serious it might be, or if Intel folks are also affected; that line points back to the bug 398002 / bug 400321 fun.

Comment 1

[philippe (part-time)]

I strongly suspect that this is the same crash I experienced last night (10.5.6/intel), while testing Troubleshoot Camino. I just had launch that build with TrC, accessed one very minimal page (on my dev server) and quit.
Going by the version info in the crash log, it must have been a home made build (10.5sdk, gcc4.2).
(crash log coming)

Comment 2

[philippe (part-time)]

Attachment: crashlog on 10.5.6 intel

Comment 3

[Steven Michaud [:smichaud] (Retired)]

(In reply to comment #0)

If Camino is truly crashing at the line identified by Talkback, that's
very strange.  That line should never be called when Camino is running
-- mNotifiedWillTerminate should always be TRUE at that point (when
the user has chosen to quit Camino).

Have there been any recent changes to how Camino behaves on quitting?

Comment 4

[Steve]

Here's the crashreporter log from my "crash on quit"
Process:         Camino [3734]
Path:            /Applications/Communications/Camino.app/Contents/MacOS/Camino
Identifier:      org.mozilla.camino
Version:         2.0b1 (2008.12.18)
Code Type:       X86 (Native)
Parent Process:  launchd [150]

Date/Time:       2009-01-06 07:11:34.953 -0800
OS Version:      Mac OS X 10.5.6 (9G55)
Report Version:  6

Exception Type:  EXC_BAD_ACCESS (SIGBUS)
Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000000
Crashed Thread:  0

Thread 0 Crashed:
0   org.mozilla.camino            	0x00026dbf -[CHBrowserView contentViewer] + 33
1   org.mozilla.camino            	0x000275c1 -[CHBrowserView shouldUnload] + 27
2   org.mozilla.camino            	0x0000429d -[BrowserWrapper browserShouldClose] + 29
3   org.mozilla.camino            	0x000327a3 -[BrowserTabView windowShouldClose] + 107
4   org.mozilla.camino            	0x00008823 -[MainController applicationShouldTerminate:] + 847
5   com.apple.AppKit              	0x90447055 -[NSApplication _docController:shouldTerminate:] + 87
6   com.apple.AppKit              	0x90446b26 -[NSApplication _shouldTerminate] + 360
7   com.apple.AppKit              	0x904467a1 -[NSApplication terminate:] + 274
8   com.apple.AppKit              	0x9036753b -[NSApplication sendAction:to:from:] + 112
9   com.apple.AppKit              	0x9041617c -[NSMenu performActionForItemAtIndex:] + 493
10  com.apple.AppKit              	0x90415e81 -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:] + 220
11  com.apple.AppKit              	0x90415b07 -[NSMenu performKeyEquivalent:] + 866
12  com.apple.AppKit              	0x904143ac -[NSApplication _handleKeyEquivalent:] + 492
13  com.apple.AppKit              	0x9033116b -[NSApplication sendEvent:] + 3999
14  com.apple.AppKit              	0x9028e69f -[NSApplication run] + 847
15  com.apple.AppKit              	0x9025b8a4 NSApplicationMain + 574
16  org.mozilla.camino            	0x00003848 main + 196
17  org.mozilla.camino            	0x0000311a _start + 216
18  org.mozilla.camino            	0x00003041 start + 41

Thread 1:
0   libSystem.B.dylib             	0x93fb1906 kevent + 10
1   com.apple.Foundation          	0x96a657ed -[NSThread main] + 45
2   com.apple.Foundation          	0x96a65394 __NSThread__main__ + 308
3   libSystem.B.dylib             	0x93fb2095 _pthread_start + 321
4   libSystem.B.dylib             	0x93fb1f52 thread_start + 34

Thread 2:
0   libSystem.B.dylib             	0x93fb830a select$DARWIN_EXTSN$NOCANCEL + 10
1   libnspr4.dylib                	0x00e3c40e poll + 258
2   libnspr4.dylib                	0x00e38cc6 PR_Poll + 134
3   org.mozilla.camino            	0x000d2fb2 nsSocketTransportService::Poll(int, unsigned int*) + 112
4   org.mozilla.camino            	0x000d34c5 nsSocketTransportService::DoPollIteration(int) + 411
5   org.mozilla.camino            	0x000d37b3 nsSocketTransportService::OnProcessNextEvent(nsIThreadInternal*, int, unsigned int) + 75
6   libxpcom_core.dylib           	0x00d9c5cc nsThread::ProcessNextEvent(int, int*) + 118
7   libxpcom_core.dylib           	0x00d656e9 NS_ProcessNextEvent_P(nsIThread*, int) + 35
8   org.mozilla.camino            	0x000d3cd5 nsSocketTransportService::Run() + 141
9   libxpcom_core.dylib           	0x00d9c629 nsThread::ProcessNextEvent(int, int*) + 211
10  libxpcom_core.dylib           	0x00d656e9 NS_ProcessNextEvent_P(nsIThread*, int) + 35
11  libxpcom_core.dylib           	0x00d9c8a1 nsThread::ThreadFunc(void*) + 139
12  libnspr4.dylib                	0x00e3a309 _pt_root + 150
13  libSystem.B.dylib             	0x93fb2095 _pthread_start + 321
14  libSystem.B.dylib             	0x93fb1f52 thread_start + 34

Thread 3:
0   libSystem.B.dylib             	0x93f81226 semaphore_timedwait_signal_trap + 10
1   libSystem.B.dylib             	0x93fb31ef _pthread_cond_wait + 1244
2   libSystem.B.dylib             	0x93ffdaaf pthread_cond_timedwait + 47
3   libnspr4.dylib                	0x00e35970 pt_TimedWait + 207
4   libnspr4.dylib                	0x00e35cc7 PR_WaitCondVar + 75
5   libxpcom_core.dylib           	0x00d9f808 TimerThread::Run() + 74
6   libxpcom_core.dylib           	0x00d9c629 nsThread::ProcessNextEvent(int, int*) + 211
7   libxpcom_core.dylib           	0x00d656e9 NS_ProcessNextEvent_P(nsIThread*, int) + 35
8   libxpcom_core.dylib           	0x00d9c8a1 nsThread::ThreadFunc(void*) + 139
9   libnspr4.dylib                	0x00e3a309 _pt_root + 150
10  libSystem.B.dylib             	0x93fb2095 _pthread_start + 321
11  libSystem.B.dylib             	0x93fb1f52 thread_start + 34

Thread 4:
0   libSystem.B.dylib             	0x93f883ae __semwait_signal + 10
1   libSystem.B.dylib             	0x93fb2d0d pthread_cond_wait$UNIX2003 + 73
2   com.apple.QuartzCore          	0x9101eab9 fe_fragment_thread + 54
3   libSystem.B.dylib             	0x93fb2095 _pthread_start + 321
4   libSystem.B.dylib             	0x93fb1f52 thread_start + 34

Thread 5:
0   libSystem.B.dylib             	0x93fd06f2 select$DARWIN_EXTSN + 10
1   libSystem.B.dylib             	0x93fb2095 _pthread_start + 321
2   libSystem.B.dylib             	0x93fb1f52 thread_start + 34

Thread 6:
0   libSystem.B.dylib             	0x93fea292 __workq_ops + 10
1   libSystem.B.dylib             	0x93fea2c2 start_wqthread + 30

Thread 7:

Thread 8:
0   libSystem.B.dylib             	0x93f81226 semaphore_timedwait_signal_trap + 10
1   libSystem.B.dylib             	0x93fb31ef _pthread_cond_wait + 1244
2   libSystem.B.dylib             	0x93fb4a73 pthread_cond_timedwait_relative_np + 47
3   com.apple.Foundation          	0x96aab75c -[NSCondition waitUntilDate:] + 236
4   com.apple.Foundation          	0x96aab570 -[NSConditionLock lockWhenCondition:beforeDate:] + 144
5   com.apple.Foundation          	0x96aab4d5 -[NSConditionLock lockWhenCondition:] + 69
6   com.apple.AppKit              	0x902fbd90 -[NSUIHeartBeat _heartBeatThread:] + 753
7   com.apple.Foundation          	0x96a657ed -[NSThread main] + 45
8   com.apple.Foundation          	0x96a65394 __NSThread__main__ + 308
9   libSystem.B.dylib             	0x93fb2095 _pthread_start + 321
10  libSystem.B.dylib             	0x93fb1f52 thread_start + 34

Thread 9:
0   libSystem.B.dylib             	0x93f8120e semaphore_wait_signal_trap + 10
1   libSystem.B.dylib             	0x93fb3206 _pthread_cond_wait + 1267
2   libSystem.B.dylib             	0x93ff8539 pthread_cond_wait + 48
3   libnspr4.dylib                	0x00e35d51 PR_WaitCondVar + 213
4   org.mozilla.camino            	0x00713ead nsSSLThread::Run() + 165
5   libnspr4.dylib                	0x00e3a309 _pt_root + 150
6   libSystem.B.dylib             	0x93fb2095 _pthread_start + 321
7   libSystem.B.dylib             	0x93fb1f52 thread_start + 34

Thread 10:
0   libSystem.B.dylib             	0x93f8120e semaphore_wait_signal_trap + 10
1   libSystem.B.dylib             	0x93fb3206 _pthread_cond_wait + 1267
2   libSystem.B.dylib             	0x93ff8539 pthread_cond_wait + 48
3   libnspr4.dylib                	0x00e35d51 PR_WaitCondVar + 213
4   org.mozilla.camino            	0x0070267d nsCertVerificationThread::Run() + 239
5   libnspr4.dylib                	0x00e3a309 _pt_root + 150
6   libSystem.B.dylib             	0x93fb2095 _pthread_start + 321
7   libSystem.B.dylib             	0x93fb1f52 thread_start + 34

Thread 11:
0   libSystem.B.dylib             	0x93fb1906 kevent + 10
1   com.apple.Foundation          	0x96a657ed -[NSThread main] + 45
2   com.apple.Foundation          	0x96a65394 __NSThread__main__ + 308
3   libSystem.B.dylib             	0x93fb2095 _pthread_start + 321
4   libSystem.B.dylib             	0x93fb1f52 thread_start + 34

Thread 0 crashed with X86 Thread State (32-bit):
  eax: 0x00000000  ebx: 0x00000000  ecx: 0x00816910  edx: 0x00000001
  edi: 0x012f9ad0  esi: 0x00000001  ebp: 0xbffff2f8  esp: 0xbffff2d0
   ss: 0x0000001f  efl: 0x00210282  eip: 0x00026dbf   cs: 0x00000017
   ds: 0x0000001f   es: 0x0000001f   fs: 0x00000000   gs: 0x00000037
  cr2: 0x00000000

Binary Images:
    0x1000 -   0x9d6fd8 +org.mozilla.camino 2.0b1 (2008.12.18) /Applications/Communications/Camino.app/Contents/MacOS/Camino
  0xd58000 -   0xd58ffe +libxpcom.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libxpcom.dylib
  0xd5d000 -   0xdc9fcf +libxpcom_core.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libxpcom_core.dylib
  0xe09000 -   0xe0e2db +libplds4.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libplds4.dylib
  0xe14000 -   0xe19d6b +libplc4.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libplc4.dylib
  0xe1f000 -   0xe44cc7 +libnspr4.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libnspr4.dylib
  0xe56000 -   0xe6bd54 +libsmime3.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libsmime3.dylib
  0xe79000 -   0xea074b +libssl3.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libssl3.dylib
  0xeae000 -   0xf7c503 +libnss3.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libnss3.dylib
  0xfb1000 -   0xfd9aab +libsoftokn3.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libsoftokn3.dylib
  0xfe5000 -  0x1079fe3 +libmozjs.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libmozjs.dylib
 0x1094000 -  0x10adfff  com.apple.frameworks.preferencepanes 12.2 (12.2) <090decd2f1c3f48031e43fdf2171469f> /System/Library/Frameworks/PreferencePanes.framework/Versions/A/PreferencePanes
 0x10c7000 -  0x10c9ffd +SharedMenusCocoa SharedMenusCocoa version 0.3 (0.0.3) /Applications/Communications/Camino.app/Contents/Frameworks/SharedMenusCocoa.framework/Versions/A/SharedMenusCocoa
 0x10cf000 -  0x112f037 +libfreebl3.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libfreebl3.dylib
 0x1139000 -  0x1194fcb +libsqlite3.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libsqlite3.dylib
 0x11a3000 -  0x11b6fef +org.andymatuschak.Sparkle 1.5 Beta (bzr) (1.5) /Applications/Communications/Camino.app/Contents/Frameworks/Sparkle.framework/Versions/A/Sparkle
 0x11c4000 -  0x11d0e77 +libnssutil3.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libnssutil3.dylib
 0x1400000 -  0x1401ffd +com.1passwd.InputManager 2.9.5 (7325) <8b4fc4d349a34592f825b1b6ebac46c8> /Library/InputManagers/1PasswdIM/1PasswdIM.bundle/Contents/MacOS/1PasswdIM
 0x1413000 -  0x141dfff +com.unsanity.smartcrashreports Smart Crash Reports version 1.5b3 (1.5b3) <7e3e7d42bb626d09e2620140ba963851> /Library/InputManagers/Smart Crash Reports/Smart Crash Reports.bundle/Contents/MacOS/Smart Crash Reports
 0x142a000 -  0x142cfff  com.apple.ExceptionHandling 1.5 (10) /System/Library/Frameworks/ExceptionHandling.framework/Versions/A/ExceptionHandling
 0x1600000 -  0x1672fff +com.DivXInc.DivXDecoder 6.4.0 (6.4.0) /Library/QuickTime/DivX Decoder.component/Contents/MacOS/DivX Decoder
 0x1680000 -  0x170ffff +com.onepasswd.onepasswdcaminobundle 2.9.8.BETA-2 (7330) <369186f2faf5d1e0ab747128609a8eaa> /Applications/1Password.app/Contents/Extensions/OnePasswdCamino.bundle/Contents/MacOS/OnePasswdCamino
0x129c5000 - 0x12b91fff +com.elgato.Turbo.component 1.3 (294)  (1.3) <6ee3c05d1689b11393d2dbefeb37a179> /Library/QuickTime/Elgato Turbo.component/Contents/MacOS/Elgato Turbo
0x12e17000 - 0x1301afc3 +com.elgato.mpegsupport EyeTV MPEG Support 1.0.8 (build 45) (1.0.8) <a68abe078aec491e8b27cfc729e99602> /Library/QuickTime/Elgato Turbo.component/Contents/Resources/EyeTV MPEG Support.component/Contents/MacOS/EyeTV MPEG Support
0x14179000 - 0x1436ffff  com.apple.RawCamera.bundle 2.0.12 (421) <02fe3f4ea6251f7b2d23d855ce5c5fd2> /System/Library/CoreServices/RawCamera.bundle/Contents/MacOS/RawCamera
0x169b9000 - 0x169bafe1  com.apple.textencoding.unicode 2.2 (2.2) <542f2b8930d6bdf16c318ffea541acab> /System/Library/TextEncodings/Unicode Encodings.bundle/Contents/MacOS/Unicode Encodings
0x16ba9000 - 0x16bc8fed  com.apple.audio.CoreAudioKit 1.5 (1.5) <82f2e52c502db7f3b32349a54209a0fe> /System/Library/Frameworks/CoreAudioKit.framework/Versions/A/CoreAudioKit
0x16d8b000 - 0x16d99feb  libSimplifiedChineseConverter.dylib ??? (???) <0436f96df3c54aab5de1fa013736d6f8> /System/Library/CoreServices/Encodings/libSimplifiedChineseConverter.dylib
0x172b7000 - 0x172d3ca7 +libnssdbm3.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libnssdbm3.dylib
0x172dc000 - 0x17313fef +libnssckbi.dylib ??? (???) /Applications/Communications/Camino.app/Contents/MacOS/libnssckbi.dylib
0x17ec0000 - 0x184e6fd3 +com.macromedia.Flash Player.plugin 10.0.12.36 (1.0.4f362) <38aeb67f6a0b43c6a341d7936603e84a> /Library/Internet Plug-Ins/Flash Player.plugin/Contents/MacOS/Flash Player
0x1aac0000 - 0x1aac5ff3  libCGXCoreImage.A.dylib ??? (???) <375e0cdb64b043378dbf637992bbfeb0> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGXCoreImage.A.dylib
0x1ce4a000 - 0x1ce5cfff  libTraditionalChineseConverter.dylib ??? (???) <3dd6a71ca9d14b661235611a9f0f0a0a> /System/Library/CoreServices/Encodings/libTraditionalChineseConverter.dylib
0x8fe00000 - 0x8fe2db43  dyld 97.1 (???) <100d362e03410f181a34e04e94189ae5> /usr/lib/dyld
0x90003000 - 0x9005fff7  com.apple.htmlrendering 68 (1.1.3) <fe87a9dede38db00e6c8949942c6bd4f> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HTMLRendering.framework/Versions/A/HTMLRendering
0x90060000 - 0x9006fffe  com.apple.DSObjCWrappers.Framework 1.3 (1.3) <09deb9e32d0d09dfb95ae569bdd2b7a4> /System/Library/PrivateFrameworks/DSObjCWrappers.framework/Versions/A/DSObjCWrappers
0x90070000 - 0x900a7fff  com.apple.SystemConfiguration 1.9.2 (1.9.2) <8b26ebf26a009a098484f1ed01ec499c> /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration
0x900a8000 - 0x9014ffeb  com.apple.QD 3.11.54 (???) <b743398c24c38e581a86e91744a2ba6e> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD
0x90151000 - 0x90153fff  com.apple.securityhi 3.0 (30817) <32d1c581312dbe0c408578df99661f96> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI
0x90154000 - 0x90160ffe  libGL.dylib ??? (???) /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib
0x90161000 - 0x90161ffa  com.apple.CoreServices 32 (32) <2fcc8f3bd5bbfc000b476cad8e6a3dd2> /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices
0x90162000 - 0x90164ff5  libRadiance.dylib ??? (???) <8a844202fcd65662bb9ab25f08c45a62> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib
0x90165000 - 0x90246ff7  libxml2.2.dylib ??? (???) <d69560099d9eb32ba7f8a17baa65a28d> /usr/lib/libxml2.2.dylib
0x90247000 - 0x90254fe7  com.apple.opengl 1.5.9 (1.5.9) <7e5048a2677b41098c84045305f42f7f> /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL
0x90255000 - 0x90a53fef  com.apple.AppKit 6.5.6 (949.43) <a3a300499bbe4f1dfebf71d752d01916> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
0x90aa6000 - 0x90eb6fef  libBLAS.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
0x90f2a000 - 0x912c7fef  com.apple.QuartzCore 1.5.7 (1.5.7) <2fed2dd7565c84a0f0c608d41d4d172c> /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore
0x912cd000 - 0x912e2ffb  com.apple.ImageCapture 5.0.1 (5.0.1) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture
0x912e3000 - 0x91462fff  com.apple.AddressBook.framework 4.1.1 (699) <60ddae72a1df8ddbc5c53df92f372b76> /System/Library/Frameworks/AddressBook.framework/Versions/A/AddressBook
0x91495000 - 0x9149cfe9  libgcc_s.1.dylib ??? (???) <f53c808e87d1184c0f9df63aef53ce0b> /usr/lib/libgcc_s.1.dylib
0x9149d000 - 0x914bcffa  libJPEG.dylib ??? (???) <e7eb56555109e23144924cd64aa8daec> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib
0x914bd000 - 0x9198ef3e  libGLProgrammability.dylib ??? (???) <5d283543ac844e7c6fa3440ac56cd265> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLProgrammability.dylib
0x9198f000 - 0x91ac7ff7  libicucore.A.dylib ??? (???) <18098dcf431603fe47ee027a60006c85> /usr/lib/libicucore.A.dylib
0x91ac8000 - 0x91acdfff  com.apple.CommonPanels 1.2.4 (85) <ea0665f57cd267609466ed8b2b20e893> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels
0x91ace000 - 0x91b61ff3  com.apple.ApplicationServices.ATS 3.4 (???) <8c51de0ec3deaef416578cd59df38754> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS
0x91d1f000 - 0x91d23fff  libGIF.dylib ??? (???) <572a32e46e33be1ec041c5ef5b0341ae> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib
0x91d8b000 - 0x91e0aff5  com.apple.SearchKit 1.2.1 (1.2.1) <3140a605db2abf56b237fa156a08b28b> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit
0x91e0b000 - 0x91e85ff8  com.apple.print.framework.PrintCore 5.5.3 (245.3) <222dade7b33b99708b8c09d1303f93fc> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore
0x91e86000 - 0x91e89fff  com.apple.help 1.1 (36) <b507b08e484cb89033e9cf23062d77de> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help
0x91e96000 - 0x91ee0fe1  com.apple.securityinterface 3.0.1 (35183) <f855cb06d2541ce544d9bcdf998b991c> /System/Library/Frameworks/SecurityInterface.framework/Versions/A/SecurityInterface
0x91f94000 - 0x91ff1ffb  libstdc++.6.dylib ??? (???) <04b812dcec670daa8b7d2852ab14be60> /usr/lib/libstdc++.6.dylib
0x91ff2000 - 0x9202cfe7  com.apple.coreui 1.2 (62) /System/Library/PrivateFrameworks/CoreUI.framework/Versions/A/CoreUI
0x9202d000 - 0x9206cfef  libTIFF.dylib ??? (???) <3589442575ac77746ae99ecf724f5f87> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib
0x9206d000 - 0x920abff7  libGLImage.dylib ??? (???) <1123b8a48bcbe9cc7aa8dd8e1a214a66> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib
0x920c4000 - 0x9220aff7  com.apple.ImageIO.framework 2.0.4 (2.0.4) <6a6623d3d1a7292b5c3763dcd108b55f> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/ImageIO
0x9220b000 - 0x9220bff8  com.apple.ApplicationServices 34 (34) <8f910fa65f01d401ad8d04cc933cf887> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices
0x9220c000 - 0x9223bfe3  com.apple.AE 402.2 (402.2) <e01596187e91af5d48653920017b8c8e> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE
0x9223c000 - 0x9224cfff  com.apple.speech.synthesis.framework 3.7.1 (3.7.1) <06d8fc0307314f8ffc16f206ad3dbf44> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis
0x9224d000 - 0x922fdfff  edu.mit.Kerberos 6.0.12 (6.0.12) <685cc018c133668d0d3ac6a1cb63cff9> /System/Library/Frameworks/Kerberos.framework/Versions/A/Kerberos
0x9236c000 - 0x9236cffd  com.apple.vecLib 3.4.2 (vecLib 3.4.2) /System/Library/Frameworks/vecLib.framework/Versions/A/vecLib
0x9236d000 - 0x929befff  com.apple.WebCore 5525.26 (5525.26.6) <8676962ab93f003cf9b10748725c1bc2> /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/WebCore
0x929c0000 - 0x929cbfe7  libCSync.A.dylib ??? (???) <e6aceed359bd228f42bc1246af5919c9> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCSync.A.dylib
0x929cc000 - 0x929f0fff  libxslt.1.dylib ??? (???) <0a9778d6368ae668826f446878deb99b> /usr/lib/libxslt.1.dylib
0x929f1000 - 0x92a00fff  libsasl2.2.dylib ??? (???) <bb7971ca2f609c070f87786a93d1041e> /usr/lib/libsasl2.2.dylib
0x92ae9000 - 0x93189fff  com.apple.CoreGraphics 1.407.2 (???) <3a91d1037afde01d1d8acdf9cd1caa14> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics
0x9318a000 - 0x93198ffd  libz.1.dylib ??? (???) <5ddd8539ae2ebfd8e7cc1c57525385c7> /usr/lib/libz.1.dylib
0x93199000 - 0x93257fff  com.apple.WebKit 5525.27 (5525.27.1) <a15e548666c9a463d61be1f114b2fa27> /System/Library/Frameworks/WebKit.framework/Versions/A/WebKit
0x93258000 - 0x93276ff3  com.apple.DirectoryService.Framework 3.5.5 (3.5.5) <f8931f64103c8a86b82e9714352f4323> /System/Library/Frameworks/DirectoryService.framework/Versions/A/DirectoryService
0x93341000 - 0x9361bff3  com.apple.CoreServices.CarbonCore 786.10 (786.10) <ec35bb05f67fe0e828d49dda88bbf6d7> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore
0x9361c000 - 0x937eaff3  com.apple.security 5.0.4 (34102) <55dda7486df4e8e1d61505be16f83a1c> /System/Library/Frameworks/Security.framework/Versions/A/Security
0x937eb000 - 0x93801fff  com.apple.DictionaryServices 1.0.0 (1.0.0) <ad0aa0252e3323d182e17f50defe56fc> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices
0x9380f000 - 0x9380fff8  com.apple.Cocoa 6.5 (???) <e064f94d969ce25cb7de3cfb980c3249> /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa
0x93ae9000 - 0x93b16feb  libvDSP.dylib ??? (???) <b232c018ddd040ec4e2c2af632dd497f> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib
0x93b54000 - 0x93b60ff9  com.apple.helpdata 1.0.1 (14.2) /System/Library/PrivateFrameworks/HelpData.framework/Versions/A/HelpData
0x93b61000 - 0x93ba2fe7  libRIP.A.dylib ??? (???) <5d0b5af7992e14de017f9a9c7cb05960> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libRIP.A.dylib
0x93ba3000 - 0x93bc7feb  libssl.0.9.7.dylib ??? (???) <c7359b7ab32b5f8574520746e10a41cc> /usr/lib/libssl.0.9.7.dylib
0x93bc8000 - 0x93c02ffe  com.apple.securityfoundation 3.0 (32989) <36f7f260187c435b2670bcb24acd4219> /System/Library/Frameworks/SecurityFoundation.framework/Versions/A/SecurityFoundation
0x93c03000 - 0x93c5cff7  libGLU.dylib ??? (???) /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib
0x93c5d000 - 0x93cdafeb  com.apple.audio.CoreAudio 3.1.1 (3.1.1) <f35477a5e23db0fa43233c37da01ae1c> /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio
0x93cdb000 - 0x93ce5feb  com.apple.audio.SoundManager 3.9.2 (3.9.2) <0f2ba6e891d3761212cf5a5e6134d683> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CarbonSound.framework/Versions/A/CarbonSound
0x93ce6000 - 0x93d37ff7  com.apple.HIServices 1.7.0 (???) <01b690d1f376e400ac873105533e39eb> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices
0x93d38000 - 0x93e6bfff  com.apple.CoreFoundation 6.5.5 (476.17) <4a70c8dbb582118e31412c53dc1f407f> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
0x93e6c000 - 0x93ec6ff7  com.apple.CoreText 2.0.3 (???) <1f1a97273753e6cfea86c810d6277680> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreText.framework/Versions/A/CoreText
0x93ec7000 - 0x93eeffff  libcups.2.dylib ??? (???) <81abd305142ad1b771024eb4a1309e2e> /usr/lib/libcups.2.dylib
0x93ef0000 - 0x93f77ff7  libsqlite3.0.dylib ??? (???) <6978bbcca4277d6ae9f042beff643f7d> /usr/lib/libsqlite3.0.dylib
0x93f78000 - 0x93f7fffe  libbsm.dylib ??? (???) <d25c63378a5029648ffd4b4669be31bf> /usr/lib/libbsm.dylib
0x93f80000 - 0x940e7ff3  libSystem.B.dylib ??? (???) <d68880dfb1f8becdbdac6928db1510fb> /usr/lib/libSystem.B.dylib
0x940fa000 - 0x940faffc  com.apple.audio.units.AudioUnit 1.5 (1.5) /System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit
0x940fb000 - 0x940fbfff  com.apple.Carbon 136 (136) <7f03616ee9261fb42dc6e6dd77a6f01c> /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon
0x9416f000 - 0x94491fe2  com.apple.QuickTime 7.5.5 (995.22.3) <07ffd134d58fdbfe377ba9007f591289> /System/Library/Frameworks/QuickTime.framework/Versions/A/QuickTime
0x94492000 - 0x94572fff  libobjc.A.dylib ??? (???) <7b92613fdf804fd9a0a3733a0674c30b> /usr/lib/libobjc.A.dylib
0x94573000 - 0x94615ff3  com.apple.QuickTimeImporters.component 7.5.5 (995.22.3) /System/Library/QuickTime/QuickTimeImporters.component/Contents/MacOS/QuickTimeImporters
0x94616000 - 0x94768ff3  com.apple.audio.toolbox.AudioToolbox 1.5.2 (1.5.2) /System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox
0x9476f000 - 0x94777fff  com.apple.DiskArbitration 2.2.1 (2.2.1) <75b0c8d8940a8a27816961dddcac8e0f> /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration
0x94a13000 - 0x94acdfe3  com.apple.CoreServices.OSServices 226.5 (226.5) <2a135d4fb16f4954290f7b72b4111aa3> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices
0x94ace000 - 0x94b10fef  com.apple.NavigationServices 3.5.2 (163) <91844980804067b07a0b6124310d3f31> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/NavigationServices.framework/Versions/A/NavigationServices
0x94b25000 - 0x94b40ffb  libPng.dylib ??? (???) <4780e979d35aa5ec2cea22678836cea5> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib
0x94b41000 - 0x94c26ff3  com.apple.CoreData 100.1 (186) <8e28162ef2288692615b52acc01f8b54> /System/Library/Frameworks/CoreData.framework/Versions/A/CoreData
0x94d29000 - 0x94d29ffd  com.apple.Accelerate.vecLib 3.4.2 (vecLib 3.4.2) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib
0x94d2a000 - 0x94db5fff  com.apple.framework.IOKit 1.5.1 (???) <f9f5f0d070e197a832d86751e1d44545> /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit
0x94db6000 - 0x95e5cffe  com.apple.QuickTimeComponents.component 7.5.5 (995.22.3) /System/Library/QuickTime/QuickTimeComponents.component/Contents/MacOS/QuickTimeComponents
0x95ead000 - 0x95eb3fff  com.apple.print.framework.Print 218.0.2 (220.1) <8bf7ef71216376d12fcd5ec17e43742c> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print
0x95ebe000 - 0x95ec3fff  com.apple.backup.framework 1.0 (1.0) /System/Library/PrivateFrameworks/Backup.framework/Versions/A/Backup
0x95ef9000 - 0x96201fff  com.apple.HIToolbox 1.5.4 (???) <3747086ba21ee419708a5cab946c8ba6> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox
0x96207000 - 0x96284fef  libvMisc.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib
0x96285000 - 0x9630ffe3  com.apple.DesktopServices 1.4.7 (1.4.7) <d16642ba22c32f67be793ebfbe67ca3a> /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv
0x96310000 - 0x96317ff7  libCGATS.A.dylib ??? (???) <386dce4b28448fb86e33e06ac466f4d8> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGATS.A.dylib
0x96318000 - 0x96361fef  com.apple.Metadata 10.5.2 (398.25) <e0572f20350523116f23000676122a8d> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata
0x96362000 - 0x963ffffc  com.apple.CFNetwork 422.11 (422.11) <2780dfc3d2186195fccb3634bfb0944b> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork
0x96400000 - 0x96409fff  com.apple.speech.recognition.framework 3.7.24 (3.7.24) <d3180f9edbd9a5e6f283d6156aa3c602> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition
0x964ba000 - 0x96581ff2  com.apple.vImage 3.0 (3.0) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage
0x96582000 - 0x965aaff7  com.apple.shortcut 1 (1.0) <057783867138902b52bc0941fedb74d1> /System/Library/PrivateFrameworks/Shortcut.framework/Versions/A/Shortcut
0x965ab000 - 0x965abffb  com.apple.installserver.framework 1.0 (8) /System/Library/PrivateFrameworks/InstallServer.framework/Versions/A/InstallServer
0x965fb000 - 0x969b9fea  libLAPACK.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib
0x969ba000 - 0x969e5fe7  libauto.dylib ??? (???) <42d8422dc23a18071869fdf7b5d8fab5> /usr/lib/libauto.dylib
0x969e6000 - 0x969e6ffd  com.apple.Accelerate 1.4.2 (Accelerate 1.4.2) /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate
0x969e7000 - 0x96a19fff  com.apple.LDAPFramework 1.4.5 (110) <cc04500cf7b6edccc75bb3fe2973f72c> /System/Library/Frameworks/LDAP.framework/Versions/A/LDAP
0x96a44000 - 0x96a5afe7  com.apple.CoreVideo 1.5.1 (1.5.1) <80b173571cdb99a829e1b8ec0a677291> /System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo
0x96a5b000 - 0x96cd6fe7  com.apple.Foundation 6.5.7 (677.22) <8fe77b5d15ecdae1240b4cb604fc6d0b> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
0x96dcc000 - 0x96dcdffc  libffi.dylib ??? (???) <a3b573eb950ca583290f7b2b4c486d09> /usr/lib/libffi.dylib
0x96dd3000 - 0x96df1fff  libresolv.9.dylib ??? (???) <a8018c42930596593ddf27f7c20fe7af> /usr/lib/libresolv.9.dylib
0x96df2000 - 0x96df9fff  com.apple.agl 3.0.9 (AGL-3.0.9) <2f39c480cfcee9358a23d61b20a6aa56> /System/Library/Frameworks/AGL.framework/Versions/A/AGL
0x96dfa000 - 0x96dfefff  libmathCommon.A.dylib ??? (???) /usr/lib/system/libmathCommon.A.dylib
0x96dff000 - 0x96ecdff3  com.apple.JavaScriptCore 5525.26 (5525.26.2) <69e219e81bc886a94c4d4b310d393ab9> /System/Library/Frameworks/JavaScriptCore.framework/Versions/A/JavaScriptCore
0x96ece000 - 0x96f99fff  com.apple.ColorSync 4.5.1 (4.5.1) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync.framework/Versions/A/ColorSync
0x96f9a000 - 0x97026ff7  com.apple.LaunchServices 290.3 (290.3) <6f9629f4ed1ba3bb313548e6838b2888> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices
0x9705e000 - 0x9706effc  com.apple.LangAnalysis 1.6.4 (1.6.4) <8b7831b5f74a950a56cf2d22a2d436f6> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis
0x97075000 - 0x97108fff  com.apple.ink.framework 101.3 (86) <bf3fa8927b4b8baae92381a976fd2079> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink
0x97109000 - 0x971bbffb  libcrypto.0.9.7.dylib ??? (???) <69bc2457aa23f12fa7d052601d48fa29> /usr/lib/libcrypto.0.9.7.dylib
0x971bc000 - 0x971d4fff  com.apple.openscripting 1.2.8 (???) <572c7452d7e740e8948a5ad07a99602b> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting
0xba900000 - 0xba916fff  libJapaneseConverter.dylib ??? (???) <b9dd2655f8262b5b870cab51b23ad18e> /System/Library/CoreServices/Encodings/libJapaneseConverter.dylib
0xbab00000 - 0xbab21fe2  libKoreanConverter.dylib ??? (???) <ece50112207cd16e0cf4b478faddaf6d> /System/Library/CoreServices/Encodings/libKoreanConverter.dylib
0xfffe8000 - 0xfffebfff  libobjc.A.dylib ??? (???) /usr/lib/libobjc.A.dylib
0xffff0000 - 0xffff1780  libSystem.B.dylib ??? (???) /usr/lib/libSystem.B.dylib

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #4)
> Here's the crashreporter log from my "crash on quit"

Steve, you're seeing bug 471409, which is very likely caused by 1Password.  (Also, in the future, please don't paste crash logs into the comments sections; attach them as text files instead.  Otherwise the bug becomes slower to load and much harder to read.)

Comment 6

[Steven Michaud [:smichaud] (Retired)]

I can reproduce this bug's crash reliably by doing the following
... though only on OS X 10.5.6 (not on OS X 10.4.11):

1) Run 1.9.0-branch Camino.

2) Close all windows.

3) Quit using cmd-q.

The regression range for this is

2007-11-08-00-trunk
2007-11-09-01-trunk

My patch for bug 400321 wasn't landed until 2007-11-10-00-trunk, so
that patch didn't cause/trigger this crash.  But nonetheless I'm
pretty sure I need to revise that patch to fix this bug.

OS X 10.5 was released in late November 2007 ... so all my tests of my
patch would have been done on OS X 10.4.X, where this crash doesn't
happen.

Comment 7

[Steven Michaud [:smichaud] (Retired)]

> The regression range for this is
>
> 2007-11-08-00-trunk
> 2007-11-09-01-trunk

Oops, this is wrong.  Even the 2007-11-08-00-trunk nightly crashes (on OS X 10.5.6) with my STR from comment #6.

Comment 8

[Steven Michaud [:smichaud] (Retired)]

(Following up comment #6)

> I can reproduce this bug's crash reliably by doing the following
> ... though only on OS X 10.5.6 (not on OS X 10.4.11):

Now I notice that one of the crashes in attachment 355202 [details] is on OS X
10.4.11.  But at least it seems to be much easier to reproduce on
10.5.6.

Comment 10

[Steven Michaud [:smichaud] (Retired)]

Attachment: Fix (1.9.0 branch)

Turns out my patch for bug 400321 missed some special cases:

1) It's possible for the nsAppShell destructor to be called "too
   early" (from Camino and perhaps other embedders) even when no
   windows are open.

   (By "too early" I mean "before code that depends on it stops
   running".)

2) The nsAppShell might be called from [MainController
   applicationWillTerminate:] before [AppShellDelegate
   applicationWillTerminate:] has been called.

   If this happens, mNotifiedWillTerminate won't yet have been set,
   and [mMainPool release] will end up being called (in the nsAppShell
   destructor) even when Camino is running -- which I didn't
   anticipate could happen.

My patch fixes these problems.

Here's a test build of Camino (with my patch) that I built myself.
Please try it and let me know your results.

http://people.mozilla.com/~stmichaud/bmo/Camino-2.0-M1.9-bugzilla471948-smichaud.dmg

My current patch is against the 1.9.0 branch.  If people have good
results with my test build, I'll post a version against the trunk and
start the review process.

Comment 11

[Steven Michaud [:smichaud] (Retired)]

> 2) The nsAppShell might be called from [MainController
>    applicationWillTerminate:] before [AppShellDelegate
>    applicationWillTerminate:] has been called.

The nsAppShell *destructor* might be called ...

Comment 12

[Steven Michaud [:smichaud] (Retired)]

(Following up comment #6)

By the way, I also crash (on OS X 10.5.6 though not on 10.4.11) if in
step 3 I quit from the Dock menu.

I don't crash if I quit from the Dock menu with any windows still
open.

Comment 13

[Stuart Morgan]

(In reply to comment #10)
> 1) It's possible for the nsAppShell destructor to be called "too
>    early" (from Camino and perhaps other embedders) even when no
>    windows are open.
> 
>    (By "too early" I mean "before code that depends on it stops
>    running".)

You've made the claim before that the real problem is a Camino bug, and if I understand correctly that's what you are saying here. If you have definitively established that this is really a Camino bug (by which I mean, something other than your incorrect assertion in bug 400321 that it's a bug for Camino to run *any* code of any kind after calling NS_TermEmbedding), could you clarify what exactly it is? I'd much rather fix it in Camino than see more hacks added to appshell.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Steven, can you please respond to Stuart's question?  This remains our topcrasher for 2.0b1, and if there's a real Camino bug at fault here, we'd like to fix it ASAP.

Comment 15

[Steven Michaud [:smichaud] (Retired)]

> Steven, can you please respond to Stuart's question?

I'll get to that next week.

In the meantime, has anyone tried my patch and tryserver build?  If so, what are your results?

Comment 16

[Ilya Sherman]

(In reply to comment #10)
> Here's a test build of Camino (with my patch) that I built myself.
> Please try it and let me know your results.
> 
> http://people.mozilla.com/~stmichaud/bmo/Camino-2.0-M1.9-bugzilla471948-smichaud.dmg
> 
> My current patch is against the 1.9.0 branch.  If people have good
> results with my test build, I'll post a version against the trunk and
> start the review process.

This seems to fix the crash for me; with un-patched Camino I could reproduce the crash with no windows open semi-consistently, whereas with the patched version not at all.

Comment 17

[Steven Michaud [:smichaud] (Retired)]

Attachment: 1.9.0 branch fix, rev1 (simpler)

Here's a new version of my patch -- same basic design, but simpler.

And here's a test build of Camino (with my new patch) that I built
myself:

http://people.mozilla.com/~stmichaud/bmo/Camino-2.0-M1.9-bugzilla471948-rev1-smichaud.dmg

Ilya (and whoever else is interested), please test this patch/build
and let us know your results.  If they're positive, I'll post a
version of my rev1 patch against the trunk, and start the review
process.

Comment 18

[Steven Michaud [:smichaud] (Retired)]

(In reply to comment #13)

Unlike with bug 400321, I don't know exactly what bug in Camino
underlies this bug.

You're welcome to look for it yourself.

Comment 19

[Stuart Morgan]

(In reply to comment #18)
> I don't know exactly what bug in Camino underlies this bug.

I think you are missing my point. You keep asserting that this class of crashes are a Camino bug. If you have any evidence to that effect, it would be helpful to know what it is. If you have no evidence that that's the case, then please stop making a point of saying that you are working around our bug as a statement of fact every time there is a crash due to appshell management of object lifetimes--if you can't offer any explanation of why you keep calling this a Camino bug, it's pretty hard to see how you could possibly know whether the bug is, in fact, a Camino bug.

> You're welcome to look for it yourself.

It's not my job to spend my time proving your (apparently unfounded) assertions.

Comment 20

[Steven Michaud [:smichaud] (Retired)]

(In reply to comment #19)

>> You're welcome to look for it yourself.
>
> It's not my job to spend my time proving your (apparently unfounded)
> assertions.

Looking for this bug would involve looking through Camino code.  And
that's not your job?

But the real problem here is that we have a perfectly suitable patch.
If you can suggest improvements, or a better alternative, please do
so.  If not, please let the rest of us do our jobs.

Comment 21

[Stuart Morgan]

(In reply to comment #20)
> If you can suggest improvements, or a better alternative, please do
> so.

If you scroll back you'll see that my objection was to the previous patch, which a) was another hack that would touch an incredible number of code paths that are completely unrelated to what it was intended to fix, and b) made an assertion in the comment that the reason the code was there was because Camino was doing something wrong, which you have yet to provide the remotest shred of evidence for.

I have no objection to this new patch, which has neither of those problems.

Comment 22

[Steven Michaud [:smichaud] (Retired)]

Attachment: 1.9.0 branch fix, rev2 (change comment)

With the evidence of this bug (where the crash actually happens *in*
NS_TermEmbedding()), I'm no longer so sure it's reasonable to expect
embedders to do little or nothing (in Cocoa code) after calling
NS_TermEmbedding().  So I've changed my comment in the nsAppShell
destructor to reflect this.

The actual code hasn't changed, so no new tryserver build is needed.

Comment 23

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #17)
> Created an attachment (id=358068) [details]
> 1.9.0 branch fix, rev1 (simpler) 
> http://people.mozilla.com/~stmichaud/bmo/Camino-2.0-M1.9-bugzilla471948-rev1-smichaud.dmg

This build also appears to fix bug 472196.

Comment 24

[Steven Michaud [:smichaud] (Retired)]

Attachment: Trunk fix, rev2

Here's a trunk version of my rev2 patch.

Comment 25

[Ilya Sherman]

(In reply to comment #17)
> Here's a new version of my patch -- same basic design, but simpler.
> 
> And here's a test build of Camino (with my new patch) that I built
> myself:
> 
> http://people.mozilla.com/~stmichaud/bmo/Camino-2.0-M1.9-bugzilla471948-rev1-smichaud.dmg
> 
> Ilya (and whoever else is interested), please test this patch/build
> and let us know your results.  If they're positive, I'll post a
> version of my rev1 patch against the trunk, and start the review
> process.

This patch, too, seems to fix the crash :)

Comment 26

[Steven Michaud [:smichaud] (Retired)]

Landed on mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/02315e999627

Comment 27

[Stuart Morgan]

Comment on attachment 358285 [details] [diff] [review]
Trunk fix, rev2

Requesting 1.9.0.x approval. Note that this should *only* affect Camino.

Comment 28

[Steven Michaud [:smichaud] (Retired)]

> Note that this should *only* affect Camino.

Yes.  I agree.

Comment 29

[Daniel Veditz [:dveditz]]

Comment on attachment 358285 [details] [diff] [review]
Trunk fix, rev2

Approved for 1.9.0.7, a=dveditz for release-drivers.

Comment 30

[Steven Michaud [:smichaud] (Retired)]

Landed on the 1.9.0 branch:
Checking in widget/src/cocoa/nsAppShell.h;
/cvsroot/mozilla/widget/src/cocoa/nsAppShell.h,v  <--  nsAppShell.h
new revision: 1.18; previous revision: 1.17
done
Checking in widget/src/cocoa/nsAppShell.mm;
/cvsroot/mozilla/widget/src/cocoa/nsAppShell.mm,v  <--  nsAppShell.mm
new revision: 1.34; previous revision: 1.33
done