472047 - Search containing "%Complete" boolean chart fails

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Teemu Mannermaa (:wicked)]

A search that uses "%Complete" in boolean chart fails to complete with error "Can't use string ("bugs.bug_id") as an ARRAY ref while "strict refs" in use at Bugzilla/Util.pm line 295." My guess is that this is a regression from changes done in bug 399371.

Calling Carp::Confess on DIE displays following call stack:
 at Bugzilla/Util.pm line 295
	Bugzilla::Util::lsearch('bugs.bug_id', 'bugs.bug_severity', 'bugs.priority', 'bugs.bug_status', 'bugs.resolution', 'map_products.name', 'bugs.remaining_time', '(SUM(ldtime.work_time)*COUNT(DISTINCT ldtime.bug_when)/COUNT(...', 'map_assigned_to.login_name', ...) called at Bugzilla/Search.pm line 1461
	Bugzilla::Search::_percentage_complete('Bugzilla::Search=HASH(0x93f2a30)', 'sequence', 'SCALAR(0x8f7cb50)', 'ff', 'SCALAR(0x8f7cb8c)', 'wherepart', 'ARRAY(0x8f62108)', 'supptables', 'ARRAY(0x8f620f0)', ...) called at Bugzilla/Search.pm line 721
	Bugzilla::Search::init('Bugzilla::Search=HASH(0x93f2a30)') called at Bugzilla/Search.pm line 74
	Bugzilla::Search::new('Bugzilla::Search', 'fields', 'ARRAY(0x91d8a60)', 'params', 'Bugzilla::CGI=HASH(0x8170954)', 'order', 'ARRAY(0x91d903c)') called at buglist.cgi line 991

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 355303 [details] [diff] [review]
patch, v1

All right, lsearch wants a ref; r=Wurblzap, provided you tested.

Comment 3

[Frédéric Buclin]

Yes, I tested.

Comment 4

[Frédéric Buclin]

tip:

Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.169; previous revision: 1.168
done

3.2:

Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.159.2.6; previous revision: 1.159.2.5
done