permissions needs to let go during shutdown-cleanse

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
10 years ago
6 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 355310 [details] [diff] [review]
release db handle for cleanse

in bug 426200 comment 6, dwitte noted that permissions had the same problem as cookies.... i know it's a bit late, but here's the patch.
Attachment #355310 - Flags: review?(dwitte)

Comment 1

10 years ago
Comment on attachment 355310 [details] [diff] [review]
release db handle for cleanse

looks good, however i remember we also ended up having debug spew in cookies by not finalizing sqlite statements before closing the db, which we fixed by adding a CloseDB() method that does things in the right order: http://hg.mozilla.org/mozilla-central/rev/fd7c994ec1e9

can you rejig this patch to do it that way? r=me with that, and no need for sr on something this simple. (please do post the patch though, so i can take a look)
Attachment #355310 - Flags: review?(dwitte) → review-
I believe this may be INVALID because we don't do shutdown-cleanse. Instead, I think jdm's work already ensures that we clear cookies at the correct time, right?

> +NOTE: Long ago there was be a "shutdown-cleanse" version of shutdown which was
> +intended to clear profile data. This is no longer sent and observer code should
> +remove support for it.

Comment 3

6 years ago
Sanitization is handled by http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js, which deals with clearing cookies and site permissions.

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.