472098 - Update context menu code after checkin of bug 462684

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Simon Paquet [:sipaq]]

Bug 462684 combined messagePaneContext and threadPaneContext to a new unified mailContext. I guess we need to adjust our Lightning context-menu code to cope with these changes.

Comment 1

[Simon Paquet [:sipaq]]

http://mxr.mozilla.org/comm-central/search?string=messagePaneContext&find=calendar&hitlimit=&tree=comm-central
http://mxr.mozilla.org/comm-central/search?string=threadPaneContext&find=calendar&hitlimit=&tree=comm-central

Comment 2

[Ian Neal]

Attachment: Fixes overlays to work with new combined mailContext v0.1

Fixes bustage caused by landing of combined mailContext

Comment 3

[Simon Paquet [:sipaq]]

Comment on attachment 355772 [details] [diff] [review]
Fixes overlays to work with new combined mailContext v0.1

I'm not a suitable reviewer for this. Moving to Berend.

Comment 4

[Berend Cornelius]

Comment on attachment 355772 [details] [diff] [review]
Fixes overlays to work with new combined mailContext v0.1

patch leaves nothing to complain - looks and works very well.
Please notice that we use let definitions in all our patches (see also https://developer.mozilla.org/en/New_in_JavaScript_1.7)
I will correct that before checking in this patch.
r=berend

Comment 5

[Berend Cornelius]

patch pushed to comm-central:

http://hg.mozilla.org/comm-central/rev/fa451dd88d63

-> fixed

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".