Closed Bug 472101 Opened 15 years ago Closed 15 years ago

Drop nsIMsgIncomingServer::rememberPassword (unneeded option)

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: standard8, Assigned: standard8)

References

()

Details

(Keywords: memory-footprint)

Attachments

(1 file)

Attached patch The fixSplinter Review
I'm splitting this out from the password manager patches to make it easier to review.

nsIMsgIncomingServer::rememberPassword looks like it was intended to be a user option, though its xul is commented out in the account manager. The only places that actually manage to set it to true are the ispdata files - i.e. when we create a new gmail account.

Looking at the code, its value is only checked in nsMsgIncomingServer::SetPassword where we always store the password locally. If rememberPassword is true, we do an additional call to StorePassword.

If you then look at StorePassword [1] you'll notice that we only do anything in that function if we have password protected the local cache... So for normal operation SetPassword doesn't need to call StorePassword.

Not only that but StorePassword is called sufficiently from other places that the password still gets set in the protecting the cache instance. This is highlighted by the fact that rememberPassword is not always set to true (I'm sure those few folks who do use it would have complained by now if it was a problem).

In any case, the StorePassword function will be going away soon, I'm just splitting this work out to make it clearer what's going on.

[1] http://hg.mozilla.org/comm-central/annotate/4382bcb7955e/mailnews/base/util/nsMsgIncomingServer.cpp#l792
Attachment #355380 - Flags: superreview?(bienvenu)
Attachment #355380 - Flags: review?(bienvenu)
Attachment #355380 - Flags: superreview?(bienvenu)
Attachment #355380 - Flags: superreview+
Attachment #355380 - Flags: review?(bienvenu)
Attachment #355380 - Flags: review+
Checked in: http://hg.mozilla.org/comm-central/rev/dfd0ad267c11
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.