nsIPrivateDOMEvent outparamdel didn't change IID

RESOLVED FIXED

Status

()

Core
DOM: Events
P2
major
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: bz, Assigned: (dormant account))

Tracking

({fixed1.9.1})

Trunk
x86
Mac OS X
fixed1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

See bug 456099 and the "Changed declaration of nsIPrivateDOMEvent without changing IID" thread in m.d.t.dom.

We need to rev this IID, since we changed this interface from 1.9 to 1.9.1...
Flags: blocking1.9.1?
Ideally, outparamdel would automatically rev the iid of any interfaces it changes.
(Assignee)

Comment 2

9 years ago
Created attachment 355425 [details] [diff] [review]
increment iid
Attachment #355425 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

9 years ago
(In reply to comment #1)
> Ideally, outparamdel would automatically rev the iid of any interfaces it
> changes.

The macrology used to set the IID makes that a bit of a tricky task to find the part of the code where the IID digits are defined which makes it hard to autorefactor. I'll think about it some more.

Comment 4

9 years ago
I bet a regex could get really close, though.
Comment on attachment 355425 [details] [diff] [review]
increment iid

Please use an actual UUID generator (worst case, |/msg firebot uuid| on irc) to do this?  And fix the comment too?
Attachment #355425 - Flags: review?(bzbarsky) → review-
(Assignee)

Comment 6

9 years ago
Created attachment 355434 [details] [diff] [review]
fix IID (using generated one)
Attachment #355425 - Attachment is obsolete: true
Attachment #355434 - Flags: review?(bzbarsky)
Comment on attachment 355434 [details] [diff] [review]
fix IID (using generated one)

Looks good.
Attachment #355434 - Flags: superreview+
Attachment #355434 - Flags: review?(bzbarsky)
Attachment #355434 - Flags: review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
(Assignee)

Comment 8

9 years ago
pushed http://hg.mozilla.org/mozilla-central/rev/d3fd61af3225
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
No harm done, since clearly this needs to land on 1.9.1 either way, but technically you should have gotten approval first (or waited until it was blocker). You also need to use the fixed1.9.1 keyword to mark bugs as fixed there.
Keywords: fixed1.9.1

Updated

9 years ago
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.