472122 - Invalid argument when hovering over toolbar/locationbar and inspector enabled

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20090104 Shiretoko/3.1b3pre ID:20090104034401 and Mozmill 1.0rc3

When the inspector is enabled and you hover over the toolbar/locationbar the following error is shown:

Error: Invalid argument
Source File: file:///C:/Mozilla/profiles/firefox%203.1/extensions/[e-mail]/resource/modules/inspection.js
Line: 186

Which is:

    if (identifier) {
      var result = {'id':elementslib._byID, 'name':elementslib._byName}[identifier.name](_document, elem.parentNode, identifier.value);
      if ( typeof(result != 'array') ) {
=>      return identifier.name+'('+json2.JSON.stringify(identifier.value)+')';
      }
    }

Comment 1

[Mikeal Rogers [:mikeal] (mrogers@)]

This bug seems to only be on Minefield. The latest release isn't effected which is why we haven't seen this before.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I can reproduce it by using Shiretoko and Minefield. What do you mean with latest release? MozMill 1.0rc3? See the first line in my comment 0. I have that version.

Comment 3

[Mikeal Rogers [:mikeal] (mrogers@)]

I meant the latest release of Firefox. This bug is still a bug in the latest mozmill trunk with Minefield though.

Should have a fix checked in tomorrow.

Comment 4

[Mikeal Rogers [:mikeal] (mrogers@)]

This turned out to be an issue with JSON.

The json2 library we have modified to be a resource in the tree has a clause that only defines it's JSON parser if one doesn't already exist. Minefield has the native JSON parser already defined but there is a bug in it that will only encode objects and arrays.

I fixed this by modifying our local copy of json2 so that we don't need to wait for that bug to be fixed in Minefield.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yeah. Fixed.