472165 - WinMobile Build Requires Tools In PATH Variable

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[John Wolfe (:wolfe)]

In order to build WinCE / WinMobile, the WinCE Shunt Library Tools have to be in the global PATH in order for the compilation to happen successfully.

In XPCOM xptcall, the assembler is being reset somewhere along the build path.

In nss, the compiler is being reset somewhere along the build path as well.

Other places may have further problems - which will show up once these first two places are fixed.

Comment 1

[John Wolfe (:wolfe)]

Attachment: v1.0 patch for top-level configuration changes

Changes to WinCE building only - within TOPSRCDIR/configure.in file

Turns out that our setting of $AS has been broken, and this patch fixes our restoring of $AS from $AS_BIN for WinCE builds ONLY.

Comment 2

[John Wolfe (:wolfe)]

Attachment: v1.0 patch for XPCOM changes

Removes setting os $AS inside xpcom/reflect/xptcall/src/md/win32/Makefile.in, as this is no longer necessary when this bug's change to $TOPSRCDIR/configure.in is applied.

Comment 3

[John Wolfe (:wolfe)]

Attachment: v1.0 patch for SECURTY module changes

Fixes for hard-coded tools within security/manager/Makefile.in and security/coreconf/WINCE.mk - all within WinCE-specific builds.

The WINCE.mk change fixes a compare that breaks because ARM != arm in string compares.  Sigh...

With the other two patches in this bug, users no longer have to hard-code the path to their build tools for WinCE building under Windows (so far, the only working build environment for WinCE builds).

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 356208 [details] [diff] [review]
v1.0 patch for top-level configuration changes

This is bogus. $(AS_BIN) will try to run `AS_BIN`. You want test -n "$AS_BIN".

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 356213 [details] [diff] [review]
v1.0 patch for SECURTY module changes

That actually looks a lot nicer.

Comment 6

[John Wolfe (:wolfe)]

Ted, if I do "test -n $AS_BIN; then" -- that test fails.  

BUT, if I do a "test -n $(AS_BIN); then" -- this test succeeds.

I do not know why the first fails and the second succeeds -- I only know what I have tested out empirically.

You can also see this IF-THEN-FI construction used in other places within the configure.in / configure files.  In fact, these other constructions within the configure.in file were what caused me to try out this patch.

Comment 7

[Doug Turner (:dougt)]

Comment on attachment 356209 [details] [diff] [review]
v1.0 patch for XPCOM changes

this is fine.

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 356213 [details] [diff] [review]
v1.0 patch for SECURTY module changes

do not make the change to security/coreconf/WINCE.mk

or this change:

-	CPU_ARCH="ARM" \
+	CPU_ARCH="$(TARGET_CPU)" \

file a separate bug with these changes.

marking this r-

Comment 9

[John Wolfe (:wolfe)]

Attachment: v2.0 patch for SECURITY module

Ted, this is the same patch as version 1.0 - except the changes for hard-coded TARGET_CPU are removed and will be placed in another bug.

This allows these three patches to be landed without the review of security/coreconf/WINCE.mk

Comment 10

[John Wolfe (:wolfe)]

Attachment: v2.0 patch for top-level configuration changes

Changed if...then...fi construction as requested by ted.

Changed to:

  if test "$AS_BIN"; then
      AS=$AS_BIN
  fi

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 356550 [details] [diff] [review]
 v2.0 patch for top-level configuration changes

+    if test "$(AS_BIN)"; then

This doesn't match your comment. I'm r+ing what you said in your comment, please make sure what you check in doesn't have the parens.

Comment 12

[John Wolfe (:wolfe)]

Attachment: v3.0 patch for top-level configuration changes

Oops - I grabbed the wrong file.  Ted, I am really sorry for taking your time to look at v2.0  

This is the ted-requested correct patch which changes a 'if test -z "$AS_BIN"; then' to 'if test "$AS_BIN"; then'

Comment 13

[John Wolfe (:wolfe)]

Comment on attachment 356577 [details] [diff] [review]
v3.0 patch for top-level configuration changes

Just r+ for ted, since this patch matches the comment for v2.0 patch (which was r+ by ted earlier today).

Comment 14

[Brad Lassey [:blassey] (use needinfo?)]

http://hg.mozilla.org/mozilla-central/rev/5752816a2426

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

http://hg.mozilla.org/mozilla-central/rev/1465d340bf6b