Closed
Bug 472177
Opened 16 years ago
Closed 16 years ago
l10n build uploads step doesn't make the build fail on failure
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: bhearsum)
References
()
Details
Attachments
(1 file)
|
596 bytes,
patch
|
coop
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1231158661.1231158688.8897.gz&fulltext=1 looks like the builds don't fail if the upload fails.
Probably lacks a haltOnFailure.
|
Assignee | |
Comment 1•16 years ago
|
||
This is my fault, I'll take care of it.
Assignee: ccooper → bhearsum
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #355590 -
Flags: review?
|
|
Assignee | |
Updated•16 years ago
|
Attachment #355590 -
Flags: review? → review?(ccooper)
|
||
Updated•16 years ago
|
Attachment #355590 -
Flags: review?(ccooper) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Comment on attachment 355590 [details] [diff] [review]
flunk on failure for uploads
Checking in factory.py;
/cvsroot/mozilla/tools/buildbotcustom/process/factory.py,v <-- factory.py
new revision: 1.71; previous revision: 1.70
done
Attachment #355590 -
Flags: checked‑in+ checked‑in+
|
|
Assignee | |
Comment 4•16 years ago
|
||
...And the master has been reconfig'ed for it.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•