l10n build uploads step doesn't make the build fail on failure

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
9 years ago
4 years ago

People

(Reporter: Pike, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1231158661.1231158688.8897.gz&fulltext=1 looks like the builds don't fail if the upload fails.

Probably lacks a haltOnFailure.
(Assignee)

Comment 1

9 years ago
This is my fault, I'll take care of it.
Assignee: ccooper → bhearsum
Status: NEW → ASSIGNED
(Assignee)

Comment 2

9 years ago
Created attachment 355590 [details] [diff] [review]
flunk on failure for uploads
Attachment #355590 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #355590 - Flags: review? → review?(ccooper)

Updated

9 years ago
Attachment #355590 - Flags: review?(ccooper) → review+
(Assignee)

Comment 3

9 years ago
Comment on attachment 355590 [details] [diff] [review]
flunk on failure for uploads

Checking in factory.py;
/cvsroot/mozilla/tools/buildbotcustom/process/factory.py,v  <--  factory.py
new revision: 1.71; previous revision: 1.70
done
Attachment #355590 - Flags: checked‑in+ checked‑in+
(Assignee)

Comment 4

9 years ago
...And the master has been reconfig'ed for it.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.