Closed
Bug 472269
Opened 15 years ago
Closed 15 years ago
LD_LIBRARY_PATH is not set when running thunderbird from mozilla/dist/bin on Solaris
Categories
(Thunderbird :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
(Keywords: fixed1.9.1)
Attachments
(2 files, 1 obsolete file)
1.46 KB,
patch
|
neil
:
superreview+
|
Details | Diff | Splinter Review |
1.44 KB,
patch
|
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
spin off from bug 259945 in run-mozilla.sh it tests for libxul.so but the release version of Thunderbird doesn't have this file. (build with -enable-static) I don't know if there's another library can be tested for this purpose.
The summary was incorrect. The result of this bug is when I do "make package" libsoftokn3.so and libfreebl3.so are not signed. Because shlibsign can't be run from mozilla/dist/bin without setting LD_LIBRARY_PATH.
Summary: Thunderbird should not use LD_LIBRARY_PATH on Solaris → LD_LIBRARY_PATH is not set when running thunderbird from mozilla/dist/bin on Solaris
Updated•15 years ago
|
Component: General → Build Config
QA Contact: general → build-config
check every .so file in top level
Attachment #358162 -
Flags: review?(wtc)
Comment 3•15 years ago
|
||
Comment on attachment 358162 [details] [diff] [review] patch r=wtc. You may want to use a lowercase variable name for SHAREDLIB.
Attachment #358162 -
Flags: review?(wtc) → review+
Attachment #358162 -
Flags: superreview?(neil)
Updated•15 years ago
|
Attachment #358162 -
Flags: superreview?(neil) → superreview+
Comment 4•15 years ago
|
||
Comment on attachment 358162 [details] [diff] [review] patch >+moz_should_set_ld_library_path() >+{ >+ if [ `uname -s` != "SunOS" ] >+ then >+ return 1 >+ fi >+ for SHAREDLIB in $MOZ_DIST_BIN/*.so >+ do >+ if [ -h $SHAREDLIB ] >+ then >+ return 1 >+ fi >+ done >+ return 0 >+} >+moz_should_set_ld_library_path >+if [ $? -eq 1 ] Zero is the success code, so ideally you would switch your return 1 and return 0 statements around and simplify your condition to: if moz_should_set_ld_library_path There are also code simplification opportunities using &&, for example: [ `uname -s` != "SunOS" ] && return 0 [ -h $SHAREDLIB] && return 0 if [ `uname -s` != "SunOS" ] && moz_should_set_ld_library_path (Note: not all of these examples work at the same time.)
comments addressed.
Assignee: nobody → ginn.chen
Attachment #358162 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #360069 -
Flags: superreview?(neil)
Comment 6•15 years ago
|
||
Comment on attachment 360069 [details] [diff] [review] patch v2 >+moz_should_set_ld_library_path >+if [ $? -eq 0 ] I still think you can write this as if moz_should_set_ld_library_path (no new sr is needed if you do make that change)
Attachment #360069 -
Flags: superreview?(neil) → superreview+
http://hg.mozilla.org/mozilla-central/rev/67c085271297
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 360070 [details] [diff] [review] patch v3 Need for thunderbird 3.0.
Attachment #360070 -
Flags: approval1.9.1?
Comment 10•15 years ago
|
||
Comment on attachment 360070 [details] [diff] [review] patch v3 a191=beltzner
Attachment #360070 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Comment 11•15 years ago
|
||
Pushed to 1.9.1 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a34218f8d45a
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•