472269 - LD_LIBRARY_PATH is not set when running thunderbird from mozilla/dist/bin on Solaris

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Ginn Chen]

spin off from bug 259945

in run-mozilla.sh
it tests for libxul.so
but the release version of Thunderbird doesn't have this file. (build with -enable-static)

I don't know if there's another library can be tested for this purpose.

Comment 1

[Ginn Chen]

The summary was incorrect.

The result of this bug is when I do "make package" libsoftokn3.so and libfreebl3.so are not signed.
Because shlibsign can't be run from mozilla/dist/bin without setting LD_LIBRARY_PATH.

Comment 2

[Ginn Chen]

Attachment: patch

check every .so file in top level

Comment 3

[Wan-Teh Chang]

Comment on attachment 358162 [details] [diff] [review]
patch

r=wtc.

You may want to use a lowercase variable name
for SHAREDLIB.

Comment 4

[[e-mail]]

Comment on attachment 358162 [details] [diff] [review]
patch

>+moz_should_set_ld_library_path()
>+{
>+	if [ `uname -s` != "SunOS" ]
>+	then
>+		return 1
>+	fi
>+	for SHAREDLIB in $MOZ_DIST_BIN/*.so
>+	do
>+		if [ -h $SHAREDLIB ]
>+		then
>+			return 1
>+		fi
>+	done
>+	return 0
>+}
>+moz_should_set_ld_library_path
>+if [ $? -eq 1 ]
Zero is the success code, so ideally you would switch your return 1 and return 0 statements around and simplify your condition to:
if moz_should_set_ld_library_path

There are also code simplification opportunities using &&, for example:
[ `uname -s` != "SunOS" ] && return 0
[ -h $SHAREDLIB] && return 0
if [ `uname -s` != "SunOS" ] && moz_should_set_ld_library_path
(Note: not all of these examples work at the same time.)

Comment 5

[Ginn Chen]

Attachment: patch v2

comments addressed.

Comment 6

[[e-mail]]

Comment on attachment 360069 [details] [diff] [review]
patch v2

>+moz_should_set_ld_library_path
>+if [ $? -eq  0 ]
I still think you can write this as

if moz_should_set_ld_library_path

(no new sr is needed if you do make that change)

Comment 7

[Ginn Chen]

Attachment: patch v3

patch to commit

Comment 8

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/67c085271297

Comment 9

[Ginn Chen]

Comment on attachment 360070 [details] [diff] [review]
patch v3

Need for thunderbird 3.0.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 360070 [details] [diff] [review]
patch v3

a191=beltzner

Comment 11

[Ginn Chen]

Pushed to 1.9.1

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a34218f8d45a