472286 - Right clicking on an attachment does not select it before the context menu appears.

Status: RESOLVED DUPLICATE of bug 533921

(Thunderbird :: Mail Window Front End, defect)

Description

[Not interested in Mozilla any more]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.5) Gecko/2008120121 Firefox/3.0.5
Build Identifier: version 2.0.0.19 (20081209)

If you right click on the attachment panel, but not on a message you should get the save all dialog. If you right click on an attachment it should select the attachment before displaying the context menu, so that it will display the context menu for the selected attachment.

Reproducible: Always

Steps to Reproduce:
1. Open Thunderbird and select an email with more than one attachment
2 [review]. Right click on one of the attachments (without selecting any of them first)
Actual Results:  
You get the generic 'save all' context menu

Expected Results:  
You should get the context menu for the attachment you have right clicked on.

Users do not expect to have to left click on an item prior to right clicking to get the correct menu for that right click. Equally, right clicking in blank space on the attachment bar should de-select all attachments before giving the context menu so you get the generic 'save all' menu.

Even more confusing for users is when you left click on the first attachment and then right click on the second and select 'save as' from the menu. This saves attachment 1 [details] [diff] [review] rather than the one you right clicked on. Very annoying.

Comment 1

[Thomas D. (:thomas8)]

This bug should be easy to confirm or resolve, but it seems to work on Windows and I don't have a MAC :/

Comment 2

[Thomas D. (:thomas8)]

Reporter, do you still see this in current nightlies?
Please include version no.

Comment 3

[Not interested in Mozilla any more]

Yes, absolutely. I've just downloaded and tested version '2.0.0.24pre (20090913)' and it still shows the issue.

Comment 4

[Richard Mlynarik]

I believe this is a duplicate of bug 448569 (which is fixed in otherwise-regressive TB3.0)

Comment 5

[Not interested in Mozilla any more]

It's still present in TB3.0.1 and Linikai.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2pre) Gecko/20100126 Lanikai/3.1b1pre

Reproduce as follows:

- Click on a message with an attachment.
- Click on the attachment within that message.
- Click on a second message with at least one attachment.
- Right click in the grey area of the attachments panel *without* clicking on an attachment.
- Select 'Save as...' from the pop-up menu.

The attachment being saved is wrong. It's the one from the previous message not this one. The only sensible fix for this is to clear the selected attachment when an email is clicked on. Anything else will be prone to problems when someone does something that you are not expecting. For example I can see that right clicking on the attachment now selects it prior saving, but that's only a partial solution.

Comment 6

[Thomas D. (:thomas8)]

(In reply to comment #5)
> The attachment being saved is wrong. It's the one from the previous message
> not this one.

That's bug 533921.

> The only sensible fix for this is to clear the selected attachment
> when an email is clicked on. Anything else will be prone to problems

Yes. I'll forward that solution to bug 533921.

> I can see that right clicking on the attachment now selects it prior saving, 
> but that's only a partial solution.

I think that solves the original issue reported by this bug, which in turn is a duplicate of bug 372956.
-> resolved dup

Check on original issues (all covered elsewhere):

(In reply to comment #0)
> If you right click on the attachment panel, but not on a message you should
> get the save all dialog.

That was covered in bug 516294, will hopefully be fixed along with bug 533921. Needs new bug if not.

> Expected Results:  
> ...
> Equally, right clicking in blank space on the attachment bar should de-select
> all attachments before giving the context menu so you get the generic 'save
> all' menu.

Absolutely. Bug 516294, will hopefully be fixed along with bug 533921.
Cf. bug 516294 comment 2.

> Even more confusing for users is when you left click on the first attachment
> and then right click on the second and select 'save as' from the menu. This
> saves attachment 1 [details] [diff] [review] rather than the one you right clicked on. Very
> annoying.

As right-clicking now correctly selects (but not focusses) attachments, this worksforme.

Comment 7

[Not interested in Mozilla any more]

(in reply to comment 6):
> I can see that right clicking on the attachment now selects it prior saving, 
> but that's only a partial solution.

No, you've missed the point entirely. Try right clicking on the attachment panel *but* not on an attachment. Just right click in the gray area away from the attachments. The option you are provided is to save the previously selected attachment in the previous message. 

The attachment does not get selected if you don't right click on it, which is the case if you have more than one attachment and want to save them all.

As this bug is not about right clicking on an attachment (but rather the space around it) it's not a duplicate of 372956. Reopening. (I can see the mistake in the original report 'not on a message' should read 'not on an attachment').

Comment 8

[Thomas D. (:thomas8)]

(In reply to comment #7)
Ian, thanks for quick response, and sorry for not being clear enough, so that apparently you've also missed my point. I still think all the issues that you raise in this bug are covered by other bugs, as I'll explain below.

> No, you've missed the point entirely. Try right clicking on the attachment
> panel *but* not on an attachment. Just right click in the gray area away from
> the attachments. The option you are provided is to save the previously
> selected attachment in the previous message.

If the above is your intention of this bug, then the current summary misses your point entirely: "Right-clicking /on/ attachment..." isn't the same as /not/ right-clicking on the attachment. As per its current summary, it's a duplicate of 372956.

> As this bug is not about right clicking on an attachment (but rather the space
> around it) it's not a duplicate of 372956. Reopening. (I can see the mistake
> in the original report 'not on a message' should read 'not on an attachment').

If this bug is about right-clicking on attachment pane blank space (which will indeed wrongly act on the previously selected attachment), then you need to change the summary, and it will be a duplicate of newer bug 516294 (which is more focused and has the attention of developers).

The problem is that the description of this bug mentions several issues which are related but we need to carefully disentangle them so that they can be acted upon. Bugs with several issues will be confusing and they seldom get any action.

Please let us know if there's any part of your bug that is NOT covered by the other bugs mentioned in comment 6.

Otherwise:
-> This bug should be resolved duplicate of either bug 372956 or bug 
516294.

Comment 9

[Not interested in Mozilla any more]

It would appear that 516294 has been closed as a duplicate of 533921. Marking this as a duplicate of that bug.