472318 - Using option + pageup/pagedown doesn't move the cursor in editor controls

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090104 Shiretoko/3.1b3pre ID:20090104020455

All Apple applications support moving the cursor by using Option + PageUp/PageDown/Home/End. The view is scrolled accordingly and the cursor is set to the new position. This doesn't work in Firefox and Thunderbird (while composing a message). Means, clearing large parts of text in a compose window has to be down by holding down Shift + Cursor Up/Down/Right/Left for a while.

If it should be a regression, it's not a recent one. It is still visible in Thunderbird 2.

Comment 1

[[e-mail]]

Attachment: Possible patch

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 391990 [details] [diff] [review]
Possible patch

Works wonderfully.

Comment 3

[liucougar]

I believe in order for this to work in richtext editor case, Bug 438840 needs to be fixed as well

Comment 4

[Markus Stange [:mstange]]

That's correct.

Comment 5

[[e-mail]]

Pushed changeset 8795a7a9817c to mozilla-central.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry, but that still doesn't work for me with the external Apple keyboard or the keyboard of my MacBook Pro and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a2pre) Gecko/20090810 Minefield/3.6a2pre ID:20090810031114

Comment 7

[Markus Stange [:mstange]]

I tested this on my 10.4 Macbook with fn+Option+Arrow up/down. All the other combinations (i.e. with Shift and/or with left/right) didn't work in Cocoa applications. Do they with the external keyboard?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Using the arrow keys wasn't the issue I have commented in comment 0. Those combinations work but you really cannot use it with an external keyboard. You will have to make knots in your fingers. Please see comment 0 how other applications on OS X support pageup/pagedown/home/end. Is there a HIG somewhere?

Comment 9

[Markus Stange [:mstange]]

(In reply to comment #8)
> Using the arrow keys wasn't the issue I have commented in comment 0.

My Macbook keyboard doesn't have pageup/down keys. Instead there's a "page" label on my up and down arrow keys, so I assumed pressing fn+arrow up/down is the same as pageup/pagedown. Is that not the case?

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Seems so. Do we have a test page where we can show up keypress events so I can compare?

Comment 11

[Markus Stange [:mstange]]

http://mozilla.pettay.fi/moztests/showkeys.html

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, I was wrong. No idea why this wasn't working the last days but now after I had to restart yesterday it works. Strange. I'll remove the home and end part from the summary because this bug doesn't take care of it.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a2pre) Gecko/20090810 Minefield/3.6a2pre ID:20090810031114

Do we have tests for it?

Comment 14

[liucougar]

a test case for this is added in Bug 438840