Remove AbcParser asserts for conditions that trigger a verify error

VERIFIED FIXED

Status

Tamarin
Virtual Machine
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Edwin Smith, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 355591 [details] [diff] [review]
make assert abort(), and remove two bogus asserts

Two asserts in AbcParser aren't checking for bugs in the abc parser, they are firing on invalid ABC input, which is what verify errors are for.
Attachment #355591 - Flags: review?(jodyer)

Updated

9 years ago
Attachment #355591 - Attachment is patch: true
Attachment #355591 - Attachment mime type: application/octet-stream → text/plain
(Reporter)

Updated

9 years ago
Attachment #355591 - Flags: review?(lhansen)

Updated

9 years ago
Attachment #355591 - Flags: review?(lhansen) → review+
(Reporter)

Comment 1

9 years ago
pushed changeset:   1261:e50d6321286f
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Updated

9 years ago
Attachment #355591 - Flags: review?(jodyer)

Comment 2

9 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.