Workers: JS/C++/JS/C++ recursion not properly guarded

RESOLVED FIXED in mozilla1.9.1

Status

()

P2
normal
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.1
fixed1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 355661 [details] [diff] [review]
Patch, v1

Workers guard against JS recursion but not when it calls back into C++. Patch attached, with testcase.
Flags: blocking1.9.1?
Attachment #355661 - Flags: superreview?(jst)
Attachment #355661 - Flags: review?(jst)
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2

Updated

10 years ago
Attachment #355661 - Flags: superreview?(jst)
Attachment #355661 - Flags: superreview+
Attachment #355661 - Flags: review?(jst)
Attachment #355661 - Flags: review+
Attachment #355661 - Flags: approval1.9.1+
Created attachment 357255 [details] [diff] [review]
Patch, v2

The previous patch failed some unit tests because the JS engine i handing us two 'too much recursion' exceptions when it should really only be giving us one. Oh well. This fixes the test and adds a new one to make sure that a throw inside the onerror handler doesn't recurse.
Attachment #355661 - Attachment is obsolete: true
Attachment #357255 - Flags: superreview?(jst)
Attachment #357255 - Flags: review?(jst)
Attachment #357255 - Flags: approval1.9.1?
Comment on attachment 357255 [details] [diff] [review]
Patch, v2

r+sr=jst
Attachment #357255 - Flags: superreview?(jst)
Attachment #357255 - Flags: superreview+
Attachment #357255 - Flags: review?(jst)
Attachment #357255 - Flags: review+
Attachment #357255 - Flags: approval1.9.1?
Pushed revision e65cb8fd2cba to mozilla-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Pushed revision 459db7715476 to mozilla-1.9.1.
Keywords: fixed1.9.1
Depends on: 491230

Updated

10 years ago
Flags: in-testsuite+
If this has been pushed in January with test cases in testsuite, can we get a verification of this bug?
Component: DOM: Mozilla Extensions → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.