472383 - Workers: JS/C++/JS/C++ recursion not properly guarded

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Workers guard against JS recursion but not when it calls back into C++. Patch attached, with testcase.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v2

The previous patch failed some unit tests because the JS engine i handing us two 'too much recursion' exceptions when it should really only be giving us one. Oh well. This fixes the test and adds a new one to make sure that a throw inside the onerror handler doesn't recurse.

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 357255 [details] [diff] [review]
Patch, v2

r+sr=jst

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Pushed revision e65cb8fd2cba to mozilla-central.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Pushed revision 459db7715476 to mozilla-1.9.1.

Comment 5

[Aakash Desai [:aakashd]]

If this has been pushed in January with test cases in testsuite, can we get a verification of this bug?