Closed Bug 472439 Opened 11 years ago Closed 11 years ago
Leaky cycle between ns
NPAPIPlugin Instance and ns Plugin Instance Peer
The peer owns the instanceOwner, and the instanceOwner owns, well, the instance. Then the instance goes and stuffs the peer into a nsCOMPtr... Patch attached that breaks the cycle on nsNPAPIPluginInstance::Stop. Also removed some unused variables and added one instance of Ctor/Dtor logging to help me figure this out. Mochitests are looking good and one of the leaks discovered in bug 386676 is now gone.
Attachment #355720 - Flags: review?(joshmoz)
Comment on attachment 355720 [details] [diff] [review] Patch, v1 Thanks!
Attachment #355720 - Flags: review?(joshmoz) → review+
11 years ago
Attachment #355720 - Flags: superreview?(jst)
Attachment #355720 - Flags: superreview?(jst) → superreview+
Comment on attachment 355720 [details] [diff] [review] Patch, v1 Wow, smart pointers for managing reference counts for you, who would've ever thunk :) Thanks for doing the extra cleanup!
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/39a8e0ea8928
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #355720 - Flags: approval1.9.1? → approval1.9.1+
pushed to mozilla-1.9.1 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5d3af2947fcc
You need to log in before you can comment on or make changes to this bug.