Closed Bug 472439 Opened 11 years ago Closed 11 years ago

Leaky cycle between nsNPAPIPluginInstance and nsPluginInstancePeer

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Attached patch Patch, v1Splinter Review
The peer owns the instanceOwner, and the instanceOwner owns, well, the instance. Then the instance goes and stuffs the peer into a nsCOMPtr...

Patch attached that breaks the cycle on nsNPAPIPluginInstance::Stop. Also removed some unused variables and added one instance of Ctor/Dtor logging to help me figure this out. Mochitests are looking good and one of the leaks discovered in bug 386676 is now gone.
Attachment #355720 - Flags: review?(joshmoz)
Comment on attachment 355720 [details] [diff] [review]
Patch, v1

Thanks!
Attachment #355720 - Flags: review?(joshmoz) → review+
Attachment #355720 - Flags: superreview?(jst)
Attachment #355720 - Flags: superreview?(jst) → superreview+
Comment on attachment 355720 [details] [diff] [review]
Patch, v1

Wow, smart pointers for managing reference counts for you, who would've ever thunk :) Thanks for doing the extra cleanup!
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/39a8e0ea8928
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #355720 - Flags: approval1.9.1?
Attachment #355720 - Flags: approval1.9.1? → approval1.9.1+
Blocks: 474866
You need to log in before you can comment on or make changes to this bug.