472439 - Leaky cycle between nsNPAPIPluginInstance and nsPluginInstancePeer

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

The peer owns the instanceOwner, and the instanceOwner owns, well, the instance. Then the instance goes and stuffs the peer into a nsCOMPtr...

Patch attached that breaks the cycle on nsNPAPIPluginInstance::Stop. Also removed some unused variables and added one instance of Ctor/Dtor logging to help me figure this out. Mochitests are looking good and one of the leaks discovered in bug 386676 is now gone.

Comment 1

[Josh Aas]

Comment on attachment 355720 [details] [diff] [review]
Patch, v1

Thanks!

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 355720 [details] [diff] [review]
Patch, v1

Wow, smart pointers for managing reference counts for you, who would've ever thunk :) Thanks for doing the extra cleanup!

Comment 3

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/39a8e0ea8928

Comment 4

[Josh Aas]

pushed to mozilla-1.9.1

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5d3af2947fcc