472453 - Moving over various elements lets the height of the inspectors pane resize

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect, P4)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090104 Shiretoko/3.1b3pre ID:20090104020455 and MozMill 1.0rc3

Using the inspector to retrieve information about various elements lets its output pane flickr. You can see this while having the mouse over the Event button.

There are different ways we could avoid that.

* Restrict the output to one line and use ellipses (with crop="middle"). It requires that the text will be copyable (that requires bug 472102). We could also make it clickable (URL style).

* Adding scroll bars (overflow-y: auto) which will show the output pane with a fixed height.

Personally I like the first way.

Comment 1

[Adam Christian]

Which "Event button" are you talking about? I am trying to repro and I can't seem to get the behavior you are talking about.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, it's called "Events" and is located on the right side of "Output". And is more a tabbutton. Sorry. :)

As Mikeal said on IRC yesterday, it's probably better to stop the inspector at all while hovering the mozmill ui.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Damn. Hit enter too fast...

But that will not fix the flickering when having elements on websites which have really long element names. :/

Comment 4

[Adam Christian]

We are no longer inspecting the Mozmill UI, and since we changed the code to use outline instead of border, you should no longer see any flickr because the nodes are no longer changing size which is what caused that issue.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Adam, depending on the element you inspect in a browser window the height of the pane within the MozMill UI, which shows the element id, is too narrow. Means for elements with xpath expressions the pane is resized. If you feel that it's the correct behavior plz close again.

Comment 6

[Adam Christian]

Ah thats what you mean by flickr, I think this is more of a choice thing, we have two options -- one is to resize so you can see all the content, the other is to give this a static height and let it create a scroll bar, what do people think?

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Personally I think it would be nice to see it as a single line. Means, we could crop the value of dxElement in the middle. All the necessary information we need are in the beginning and at the end. If you copy the content everything should be copied into the clipboard.

Here an example:
<label id="dxElement" ondblclick="copyToClipboard(this.value)" crop="center" style="width: 600px;"/>

Because we mess-up with the window width in some way, I have to set the width to 600px. Further I think we should remove the html tags and use xul widgets here. What do you think about?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Example with a label

Comment 9

[cmtalbert]

Still an issue with the new UI on trunk?

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

On trunk the horizontal scrollbar is shown and hidden when moving over several elements we have to do a lookup. Its a bit of flaky line wrapping which doesn't seem to be happen at all.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Only a visual problem => P4

Comment 12

[Tracy Walker [:tracy]]

This looks fixed to me since going to 1.1's new UI.  The insane flickering like on older versions is no longer present. The occasional scroll bar appearing for extra long spaceless paths seems OK to me.

Comment 13

[Mikeal Rogers [:mikeal] (mrogers@)]

Fixed in new UI.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, that looks much cleaner and should be all we can do here. Marking as verified.