472501 - [FIX]More XUL frame construction weirdness

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Boris Zbarsky [:bzbarsky]]

There are two more places in ConstructXULFrame where we should be checking the namespace.  Also, there's weirdness where only XUL frames check with the binding manager whether to process kids.  I think all frames should do that.  I checked on try server, and performance impact is nonexistent (probably because of the bit-check which fast-paths the whole thing for HTML in the typical case).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

Comment 2

[Neil Deakin]

Comment on attachment 355770 [details] [diff] [review]
Proposed fix

OK, but there's another tooltip reference a bit earlier up in the NS_STYLE_DISPLAY_POPUP check as well.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Oh, right.  That one's removed by a different patch in my queue, actually (moves it out of frame constructor entirely, in fact).  With any luck I'll be attaching a whole bunch of stuff like that to a still-to-be-filed bug sometime after the freeze.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/38889a06fb52