Last Comment Bug 472541 - use tango palette for quote borders
: use tango palette for quote borders
Status: RESOLVED FIXED
tango
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: Thunderbird 3.0b2
Assigned To: Bryan Clark (DevTools PM) [@clarkbw]
:
Mentors:
Depends on:
Blocks: 415415
  Show dependency treegraph
 
Reported: 2009-01-07 11:51 PST by Bryan Clark (DevTools PM) [@clarkbw]
Modified: 2009-06-01 14:11 PDT (History)
11 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
tango palette quote borders (1.41 KB, patch)
2009-01-07 11:51 PST, Bryan Clark (DevTools PM) [@clarkbw]
no flags Details | Diff | Splinter Review
472541-v2.patch (1.41 KB, patch)
2009-01-12 12:43 PST, Bryan Clark (DevTools PM) [@clarkbw]
no flags Details | Diff | Splinter Review
v2.patch (2.33 KB, patch)
2009-01-14 01:02 PST, Bryan Clark (DevTools PM) [@clarkbw]
no flags Details | Diff | Splinter Review
tango-message-quotes.png (63.34 KB, image/png)
2009-01-14 01:03 PST, Bryan Clark (DevTools PM) [@clarkbw]
no flags Details
tango palette, borders on both sides (2.33 KB, patch)
2009-02-04 13:17 PST, Bryan Clark (DevTools PM) [@clarkbw]
mkmelin+mozilla: review+
Details | Diff | Splinter Review
tango palette, borders on both sides; w/ nits addresed (2.33 KB, patch)
2009-02-05 14:13 PST, Bryan Clark (DevTools PM) [@clarkbw]
clarkbw: review+
Details | Diff | Splinter Review
Deep threaded newsgroup post (29.13 KB, image/gif)
2009-02-10 16:05 PST, Joe Sabash [:JoeS1]
no flags Details

Description Bryan Clark (DevTools PM) [@clarkbw] 2009-01-07 11:51:53 PST
Created attachment 355817 [details] [diff] [review]
tango palette quote borders

here's a simple patch to use the softer tango palette for reply borders in the qute theme.  I also removed the dual left/right border in favor of a single left border.

I'm waiting on bug 406742 to land before requesting review; and then I'll likely split out the colors into each theme anyway.
Comment 1 Magnus Melin 2009-01-07 12:35:00 PST
I'll land bug 406742 as after bug 440594 to avoid extra work.
Comment 2 Bryan Clark (DevTools PM) [@clarkbw] 2009-01-12 12:43:23 PST
Created attachment 356573 [details] [diff] [review]
472541-v2.patch

Here's a patch for the gnomestripe theme to use the Tango palette of colors instead of the old blue, maroon, teal, purple, and green.  

As before this removes the dual side bordering in favor of a single, left only border.  I'm not sure, but we may want to have rules for which side depending on rtl, ltr.
Comment 3 Magnus Melin 2009-01-12 13:41:27 PST
The colors are nice, but one side only borders look quite lonely, imo.
Comment 4 Bryan Clark (DevTools PM) [@clarkbw] 2009-01-14 01:02:16 PST
Created attachment 356914 [details] [diff] [review]
v2.patch

Here's a patch that pulls in the signature, signature links and body links to all use the same tango palette.  screenshot to follow.
Comment 5 Bryan Clark (DevTools PM) [@clarkbw] 2009-01-14 01:03:11 PST
Created attachment 356915 [details]
tango-message-quotes.png

screenshot of the v2.1... patch working on the m.d.a.t
Comment 6 Bryan Clark (DevTools PM) [@clarkbw] 2009-01-14 01:10:01 PST
> The colors are nice, but one side only borders look quite lonely, imo.

I will make an extension that adds that second border back to the other side just for you. :)  But in general I do think it's a cleaner look to have a single border on the left.
Comment 7 Dão Gottwald [:dao] 2009-01-20 00:40:23 PST
Comment on attachment 356914 [details] [diff] [review]
v2.patch

>+a {
>+  color: rgb(32, 74, 135); /* Sky Blue 3 */
>+}

-moz-nativehyperlinktext?

Otherwise you should force a white background color on the message body, which I think isn't done currently.
Comment 8 Dão Gottwald [:dao] 2009-01-20 00:46:45 PST
(In reply to comment #3)
> The colors are nice, but one side only borders look quite lonely, imo.

Also note that using only border-left (rather than both sides or -moz-border-start) ignores rtl. I don't know if Tb supports rtl in general and particularly in the message body.
Comment 9 Bryan Clark (DevTools PM) [@clarkbw] 2009-01-27 14:30:27 PST
(In reply to comment #8)
> Also note that using only border-left (rather than both sides or
> -moz-border-start) ignores rtl. I don't know if Tb supports rtl in general and
> particularly in the message body.

I'm not sure who would know that, so I'm cc'ing david & dmose.

If our message viewer HTML doc can insert some kind of attribute about rtl then we can just setup the border correctly with css rules.

FF uses this: <body dir="ltr">  in it's error pages that are mostly HTML these days.  It allows for a correcting css rule like:

  body[dir="rtl"] blockquote { border-right: 2px solid; border-left: none; }
Comment 10 Andreas Nilsson (:andreasn) 2009-01-27 14:34:52 PST
The colors you selected are great. Tried it out with using #3465a4, #75507b and #73d216 instead, but that just looked too heavy.
Personally, I'm not really going to miss the right border.
Comment 11 Magnus Melin 2009-01-27 22:29:52 PST
Hm, is mixed direction (both ltr and rtl for different paragraphs) documents common? CC:ing some people who might know.
Comment 12 :Ehsan Akhgari 2009-01-28 09:36:10 PST
(In reply to comment #11)
> Hm, is mixed direction (both ltr and rtl for different paragraphs) documents
> common? CC:ing some people who might know.

I assmue by mixed direction you mean paragraph directionality (not text directionality).  Mixed direction text is *very* common (any text in Arabic or Persian containing numbers is mixed directions, since these languages write numbers from left to right).  If you're talking about documents, then no they're not that common.  However, for emails I think they're pretty common.  For example, my email signature is LTR, but when I type an email in Persian, the text would be RTL.  This results in an email with both LTR and RTL paragraphs.
Comment 13 Bryan Clark (DevTools PM) [@clarkbw] 2009-02-04 13:17:45 PST
Created attachment 360572 [details] [diff] [review]
tango palette, borders on both sides

Here's an updated patch that I'd like to land for b2.

Since it seems we might have a bit of a time getting the borders to play well with ltr/rtl inside the documents I've put back *both* borders.  If some kind of ltr/rtl attribute gets set on paragraphs in the future it would be trivial for us to make this change happen; if anyone still wanted to.

I've continued with the Sky Blue 3 for the {a} element color because it fits with the overall theme colors. -moz-nativehyperlinktext would set the color that already gets set naturally, #0000FF, which is not a good looking link color.

magnus, can review this for me?

Once we get this review done for the gnomestripe theme we should be able to copy the rules over to the other themes and land them as well.
Comment 14 Magnus Melin 2009-02-05 11:11:52 PST
Comment on attachment 360572 [details] [diff] [review]
tango palette, borders on both sides

Looks good!

One nit: for consistency please drop the spaces in the tango rbg colors, in the places you have them between the numbers. Or maybe even better use the hex codes from
http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines

... I don't know where you found the rgb codes.

>+a {
>+  color: rgb(32, 74, 135); /* Sky Blue 3 */
>+}
Comment 15 Bryan Clark (DevTools PM) [@clarkbw] 2009-02-05 14:07:11 PST
Just reading the newsgroup post from sipaq I realize I probably could have used -moz-border-start to get the left/right border correctly depending on rtl/ltr values.  Perhaps another bug...
Comment 16 Bryan Clark (DevTools PM) [@clarkbw] 2009-02-05 14:13:32 PST
Created attachment 360801 [details] [diff] [review]
tango palette, borders on both sides; w/ nits addresed

(In reply to comment #14)
> (From update of attachment 360572 [details] [diff] [review])
> Looks good!

Thanks!

> One nit: for consistency please drop the spaces in the tango rbg colors, in the
> places you have them between the numbers. 

Spaces removed in this final patch.

> Or maybe even better use the hex
> codes from
> http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines
> 
> ... I don't know where you found the rgb codes.

hex codes?  you and I are living in the future where there is nothing but rgb values. :)  Plus I use Inkscape for everything which provides the rgb/rgba numbers.

carrying the review+ forward.  this should be ready to check-in
Comment 17 Mark Banner (:standard8) 2009-02-10 08:09:59 PST
Checked in: http://hg.mozilla.org/comm-central/rev/a74da3faa1f7
Comment 18 Joe Sabash [:JoeS1] 2009-02-10 16:05:23 PST
Created attachment 361660 [details]
Deep threaded newsgroup post
Comment 19 Joe Sabash [:JoeS1] 2009-02-10 16:07:17 PST
Please don't give up on the idea of left border only.
Imagine what the above post would look like with left and right borders
Comment 20 Dão Gottwald [:dao] 2009-02-11 05:34:14 PST
Regardless of the side and the colors, the borders seem suboptimal. I added this to userContent.css long ago:

blockquote[type="cite"] {
  background-color: rgba(0,0,0,.09);
}

This improves readability quite a bit, I think, but I'm not sure if it's an option for the default styling.
Comment 21 Bryan Clark (DevTools PM) [@clarkbw] 2009-06-01 14:11:03 PDT
marking this blocking of bug 415415 post close.  I've created bug 495860 for moving to a single border

Note You need to log in before you can comment on or make changes to this bug.