Note: There are a few cases of duplicates in user autocompletion which are being worked on.

use tango palette for quote borders

RESOLVED FIXED in Thunderbird 3.0b2

Status

Thunderbird
Mail Window Front End
--
enhancement
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: clarkbw, Assigned: clarkbw)

Tracking

Trunk
Thunderbird 3.0b2

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tango)

Attachments

(3 attachments, 4 obsolete attachments)

Created attachment 355817 [details] [diff] [review]
tango palette quote borders

here's a simple patch to use the softer tango palette for reply borders in the qute theme.  I also removed the dual left/right border in favor of a single left border.

I'm waiting on bug 406742 to land before requesting review; and then I'll likely split out the colors into each theme anyway.
(Assignee)

Updated

9 years ago
Whiteboard: tango

Comment 1

9 years ago
I'll land bug 406742 as after bug 440594 to avoid extra work.
(Assignee)

Comment 2

9 years ago
Created attachment 356573 [details] [diff] [review]
472541-v2.patch

Here's a patch for the gnomestripe theme to use the Tango palette of colors instead of the old blue, maroon, teal, purple, and green.  

As before this removes the dual side bordering in favor of a single, left only border.  I'm not sure, but we may want to have rules for which side depending on rtl, ltr.
Attachment #355817 - Attachment is obsolete: true

Comment 3

9 years ago
The colors are nice, but one side only borders look quite lonely, imo.
(Assignee)

Comment 4

9 years ago
Created attachment 356914 [details] [diff] [review]
v2.patch

Here's a patch that pulls in the signature, signature links and body links to all use the same tango palette.  screenshot to follow.
Attachment #356573 - Attachment is obsolete: true
(Assignee)

Comment 5

9 years ago
Created attachment 356915 [details]
tango-message-quotes.png

screenshot of the v2.1... patch working on the m.d.a.t
(Assignee)

Comment 6

9 years ago
> The colors are nice, but one side only borders look quite lonely, imo.

I will make an extension that adds that second border back to the other side just for you. :)  But in general I do think it's a cleaner look to have a single border on the left.
Comment on attachment 356914 [details] [diff] [review]
v2.patch

>+a {
>+  color: rgb(32, 74, 135); /* Sky Blue 3 */
>+}

-moz-nativehyperlinktext?

Otherwise you should force a white background color on the message body, which I think isn't done currently.
(In reply to comment #3)
> The colors are nice, but one side only borders look quite lonely, imo.

Also note that using only border-left (rather than both sides or -moz-border-start) ignores rtl. I don't know if Tb supports rtl in general and particularly in the message body.
(Assignee)

Comment 9

9 years ago
(In reply to comment #8)
> Also note that using only border-left (rather than both sides or
> -moz-border-start) ignores rtl. I don't know if Tb supports rtl in general and
> particularly in the message body.

I'm not sure who would know that, so I'm cc'ing david & dmose.

If our message viewer HTML doc can insert some kind of attribute about rtl then we can just setup the border correctly with css rules.

FF uses this: <body dir="ltr">  in it's error pages that are mostly HTML these days.  It allows for a correcting css rule like:

  body[dir="rtl"] blockquote { border-right: 2px solid; border-left: none; }
The colors you selected are great. Tried it out with using #3465a4, #75507b and #73d216 instead, but that just looked too heavy.
Personally, I'm not really going to miss the right border.

Comment 11

9 years ago
Hm, is mixed direction (both ltr and rtl for different paragraphs) documents common? CC:ing some people who might know.
(In reply to comment #11)
> Hm, is mixed direction (both ltr and rtl for different paragraphs) documents
> common? CC:ing some people who might know.

I assmue by mixed direction you mean paragraph directionality (not text directionality).  Mixed direction text is *very* common (any text in Arabic or Persian containing numbers is mixed directions, since these languages write numbers from left to right).  If you're talking about documents, then no they're not that common.  However, for emails I think they're pretty common.  For example, my email signature is LTR, but when I type an email in Persian, the text would be RTL.  This results in an email with both LTR and RTL paragraphs.
Created attachment 360572 [details] [diff] [review]
tango palette, borders on both sides

Here's an updated patch that I'd like to land for b2.

Since it seems we might have a bit of a time getting the borders to play well with ltr/rtl inside the documents I've put back *both* borders.  If some kind of ltr/rtl attribute gets set on paragraphs in the future it would be trivial for us to make this change happen; if anyone still wanted to.

I've continued with the Sky Blue 3 for the {a} element color because it fits with the overall theme colors. -moz-nativehyperlinktext would set the color that already gets set naturally, #0000FF, which is not a good looking link color.

magnus, can review this for me?

Once we get this review done for the gnomestripe theme we should be able to copy the rules over to the other themes and land them as well.
Attachment #356914 - Attachment is obsolete: true
Attachment #360572 - Flags: review?(mkmelin+mozilla)

Comment 14

9 years ago
Comment on attachment 360572 [details] [diff] [review]
tango palette, borders on both sides

Looks good!

One nit: for consistency please drop the spaces in the tango rbg colors, in the places you have them between the numbers. Or maybe even better use the hex codes from
http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines

... I don't know where you found the rgb codes.

>+a {
>+  color: rgb(32, 74, 135); /* Sky Blue 3 */
>+}
Attachment #360572 - Flags: review?(mkmelin+mozilla) → review+
Just reading the newsgroup post from sipaq I realize I probably could have used -moz-border-start to get the left/right border correctly depending on rtl/ltr values.  Perhaps another bug...
Created attachment 360801 [details] [diff] [review]
tango palette, borders on both sides; w/ nits addresed

(In reply to comment #14)
> (From update of attachment 360572 [details] [diff] [review])
> Looks good!

Thanks!

> One nit: for consistency please drop the spaces in the tango rbg colors, in the
> places you have them between the numbers. 

Spaces removed in this final patch.

> Or maybe even better use the hex
> codes from
> http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines
> 
> ... I don't know where you found the rgb codes.

hex codes?  you and I are living in the future where there is nothing but rgb values. :)  Plus I use Inkscape for everything which provides the rgb/rgba numbers.

carrying the review+ forward.  this should be ready to check-in
Attachment #360572 - Attachment is obsolete: true
Attachment #360801 - Flags: review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/a74da3faa1f7
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Comment 18

9 years ago
Created attachment 361660 [details]
Deep threaded newsgroup post

Comment 19

9 years ago
Please don't give up on the idea of left border only.
Imagine what the above post would look like with left and right borders
Regardless of the side and the colors, the borders seem suboptimal. I added this to userContent.css long ago:

blockquote[type="cite"] {
  background-color: rgba(0,0,0,.09);
}

This improves readability quite a bit, I think, but I'm not sure if it's an option for the default styling.
marking this blocking of bug 415415 post close.  I've created bug 495860 for moving to a single border
Blocks: 415415
You need to log in before you can comment on or make changes to this bug.