472553 - Annotations required by jsstack.js analysis

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Graydon Hoare :graydon]

Attachment: A few annotations required by the current code

The treehydra analysis jsstack.js requires some annotations in the tracemonkey JIT code; from time to time these may be forgotten or lost. This bug is for tracking patches that add them.

Pending patches on this bug should block pushes to m-c (really, a static analysis tinderbox on tm would be better).

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 355835 [details] [diff] [review]
A few annotations required by the current code

Please also mark these JS_REQUIRES_STACK at their declarations.  r=me with that (assuming that doesn't reveal further problems).

(For bonus points, make jsstack.js reject this patch because the declarations and definitions don't agree... :-P)

Comment 2

[Graydon Hoare :graydon]

Patch #1 here committed: http://hg.mozilla.org/tracemonkey/rev/8527a7798a81

Should I close for now and reopen when a new patch appears? Or just leave open indefinitely?

Comment 3

[Jason Orendorff [:jorendorff]]

How about let's resolve this bug and mark future regressions as blocking this.

Comment 4

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0885573f5b95

Comment 5

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0885573f5b95

Comment 6

[Bob Clary [:bc] (inactive)]

verified 1.9.1, 1.9.2 based on green static analysis tinderbox on mozilla-central, tracemonkey.