472590 - "ASSERTION: imgIRequest::STATUS_FRAME_COMPLETE not set"

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: imgIRequest::STATUS_FRAME_COMPLETE not set: '(status & imgIRequest::STATUS_FRAME_COMPLETE)', file /Users/jruderman/central/layout/base/nsImageLoader.cpp, line 170

Comment 1

[Jesse Ruderman]

Huh, and when loaded from Bugzilla, it triggers a warning about mixed secure/insecure content.

Comment 2

[Boris Zbarsky [:bzbarsky]]

The status in this case is LOAD_COMPLETE|SIZE_AVAILABLE.

This looks like a bug in imgRequest::NotifyProxyListener to me: it's sending notifications that it doesn't have the status bits for (presumably because there are no frames in the image in this case or something?).

Comment 3

[Joe Drew (not getting mail)]

Attachment: Always call OnStopFrame(), even if we didn't decode any rows

Yes, this is almost certainly an invalid GIF, since we don't decode any rows of data. However, even in this case, we should call OnStopFrame(), because that's part of the contract for decoders.

Comment 4

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/7f994763ccc1

Comment 5

[Joe Drew (not getting mail)]

Attachment: 1.9.0/1.9.1 branch patch

This is simply reapplying the patch to 1.9.1 (changes context only). I'm requesting approval for this patch because it will make fixing bug 511689 on the branch cleaner.

Comment 6

[Joe Drew (not getting mail)]

Comment on attachment 401963 [details] [diff] [review]
1.9.0/1.9.1 branch patch

This same patch also applies to 1.9.0 with an offset of -7 lines.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 401963 [details] [diff] [review]
1.9.0/1.9.1 branch patch

Approved for 1.9.1.4 and 1.9.0.15, a=dveditz

Comment 8

[Joe Drew (not getting mail)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/43e8eb5ccab2

Comment 9

[Joe Drew (not getting mail)]

Checking in nsGIFDecoder2.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/gif/nsGIFDecoder2.cpp,v  <--  nsGIFDecoder2.cpp
new revision: 1.105; previous revision: 1.104
done

Comment 10

[Al Billings [:abillings - ex-MoCo]]

Verified fixed in 1.9.0 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.0.15pre) Gecko/2009092315 GranParadiso/3.0.15pre (my debug build) using the testcase attached.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed on 1.9.1 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.5pre) Gecko/20091008 Shiretoko/3.5.5pre ID:20091008213747