Closed Bug 472590 Opened 11 years ago Closed 11 years ago

"ASSERTION: imgIRequest::STATUS_FRAME_COMPLETE not set"

Categories

(Core :: ImageLib, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1
Tracking Status
blocking1.9.1 --- .4+
status1.9.1 --- .4-fixed

People

(Reporter: jruderman, Assigned: joe)

References

(Blocks 1 open bug)

Details

(4 keywords)

Attachments

(3 files)

Attached file testcase
###!!! ASSERTION: imgIRequest::STATUS_FRAME_COMPLETE not set: '(status & imgIRequest::STATUS_FRAME_COMPLETE)', file /Users/jruderman/central/layout/base/nsImageLoader.cpp, line 170
Huh, and when loaded from Bugzilla, it triggers a warning about mixed secure/insecure content.
The status in this case is LOAD_COMPLETE|SIZE_AVAILABLE.

This looks like a bug in imgRequest::NotifyProxyListener to me: it's sending notifications that it doesn't have the status bits for (presumably because there are no frames in the image in this case or something?).
Component: Layout: Images → ImageLib
QA Contact: layout.images → imagelib
Yes, this is almost certainly an invalid GIF, since we don't decode any rows of data. However, even in this case, we should call OnStopFrame(), because that's part of the contract for decoders.
Assignee: nobody → joe
Attachment #377579 - Flags: review?(vladimir)
http://hg.mozilla.org/mozilla-central/rev/7f994763ccc1
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
This is simply reapplying the patch to 1.9.1 (changes context only). I'm requesting approval for this patch because it will make fixing bug 511689 on the branch cleaner.
Attachment #401963 - Flags: approval1.9.1.4?
Comment on attachment 401963 [details] [diff] [review]
1.9.0/1.9.1 branch patch

This same patch also applies to 1.9.0 with an offset of -7 lines.
Attachment #401963 - Flags: approval1.9.0.15?
Flags: wanted1.9.0.x+
Comment on attachment 401963 [details] [diff] [review]
1.9.0/1.9.1 branch patch

Approved for 1.9.1.4 and 1.9.0.15, a=dveditz
Attachment #401963 - Flags: approval1.9.1.4?
Attachment #401963 - Flags: approval1.9.1.4+
Attachment #401963 - Flags: approval1.9.0.15?
Attachment #401963 - Flags: approval1.9.0.15+
Attachment #401963 - Attachment description: 1.9.1 branch patch → 1.9.0/1.9.1 branch patch
blocking1.9.1: --- → .4+
Flags: blocking1.9.0.15+
Checking in nsGIFDecoder2.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/gif/nsGIFDecoder2.cpp,v  <--  nsGIFDecoder2.cpp
new revision: 1.105; previous revision: 1.104
done
Keywords: fixed1.9.0.15
Verified fixed in 1.9.0 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.0.15pre) Gecko/2009092315 GranParadiso/3.0.15pre (my debug build) using the testcase attached.
Verified fixed on 1.9.1 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.5pre) Gecko/20091008 Shiretoko/3.5.5pre ID:20091008213747
Keywords: verified1.9.1
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.