If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

adding Mouse Events Listener to embedding

RESOLVED INCOMPLETE

Status

()

Core
Embedding: APIs
RESOLVED INCOMPLETE
9 years ago
a year ago

People

(Reporter: Anton Rogaynis (antonr), Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

9 years ago
Created attachment 355990 [details] [diff] [review]
fix for mouse listener

Mouse event listener should be defined in embedding to provide possibility for example to stop propagation of event, implement kinetic scrolling etc.
(Reporter)

Updated

9 years ago
Attachment #355990 - Flags: review?(mark.finkle)
(Reporter)

Comment 1

9 years ago
Of course would be nice to have separate function (like ::AddDOMListeners) to register listeners. But since there is the only one listener don't think it's required. That will be implemented while adding new ones. 
Also don't think that it's better to have macros for adding listeners.
Opinions?
(Reporter)

Comment 2

9 years ago
Moreover this patch is a mouse listener stub which does not require to fix platform dependent functionality.
Attachment #355990 - Flags: review?(mark.finkle) → review-
Comment on attachment 355990 [details] [diff] [review]
fix for mouse listener

>diff -r a02feed00db5 common/DOMEventListener.cpp
>-NS_IMPL_ISUPPORTS1(DOMEventListener,
>-                   nsIDOMEventListener)
>+NS_IMPL_ADDREF(DOMEventListener) 
>+NS_IMPL_RELEASE(DOMEventListener) 
>+NS_INTERFACE_MAP_BEGIN(DOMEventListener)
>+    NS_INTERFACE_MAP_ENTRY_AMBIGUOUS(nsIDOMEventListener, nsIDOMMouseListener) 
>+    NS_INTERFACE_MAP_ENTRY(nsIDOMMouseListener)
>+NS_INTERFACE_MAP_END 

Couldn't we use:
NS_IMPL_ISUPPORTS2(DOMEventListener, nsIDOMEventListener, nsIDOMMouseListener)


Can you add the needed changes to the gtk makefiles? (assuming the include folder "content" will need to be added)
(Reporter)

Comment 4

9 years ago
Created attachment 356034 [details] [diff] [review]
fix with suggestion

agree about using
NS_IMPL_ISUPPORTS2(DOMEventListener, nsIDOMEventListener, nsIDOMMouseListener)

but gtk patform using autotools and .pc files that does not require to have hardcoded "content" in Makefile.
Attachment #356034 - Flags: review?(mark.finkle)
(Reporter)

Comment 5

9 years ago
Created attachment 356304 [details] [diff] [review]
updated patch

I've updated patch according changes in trunk
Attachment #356034 - Attachment is obsolete: true
Attachment #356304 - Flags: review?(mark.finkle)
Attachment #356034 - Flags: review?(mark.finkle)
(Reporter)

Comment 6

9 years ago
Created attachment 356307 [details] [diff] [review]
prev patch + minor cleaning
Attachment #356304 - Attachment is obsolete: true
Attachment #356307 - Flags: review?(mark.finkle)
Attachment #356304 - Flags: review?(mark.finkle)
(Reporter)

Updated

9 years ago
Blocks: 472691
Attachment #356307 - Flags: review?(mark.finkle)

Comment 7

a year ago
Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.