Created attachment 355990 [details] [diff] [review] fix for mouse listener Mouse event listener should be defined in embedding to provide possibility for example to stop propagation of event, implement kinetic scrolling etc.
Attachment #355990 - Flags: review?(mark.finkle)
Of course would be nice to have separate function (like ::AddDOMListeners) to register listeners. But since there is the only one listener don't think it's required. That will be implemented while adding new ones. Also don't think that it's better to have macros for adding listeners. Opinions?
Moreover this patch is a mouse listener stub which does not require to fix platform dependent functionality.
Attachment #355990 - Flags: review?(mark.finkle) → review-
Comment on attachment 355990 [details] [diff] [review] fix for mouse listener >diff -r a02feed00db5 common/DOMEventListener.cpp >-NS_IMPL_ISUPPORTS1(DOMEventListener, >- nsIDOMEventListener) >+NS_IMPL_ADDREF(DOMEventListener) >+NS_IMPL_RELEASE(DOMEventListener) >+NS_INTERFACE_MAP_BEGIN(DOMEventListener) >+ NS_INTERFACE_MAP_ENTRY_AMBIGUOUS(nsIDOMEventListener, nsIDOMMouseListener) >+ NS_INTERFACE_MAP_ENTRY(nsIDOMMouseListener) >+NS_INTERFACE_MAP_END Couldn't we use: NS_IMPL_ISUPPORTS2(DOMEventListener, nsIDOMEventListener, nsIDOMMouseListener) Can you add the needed changes to the gtk makefiles? (assuming the include folder "content" will need to be added)
Created attachment 356034 [details] [diff] [review] fix with suggestion agree about using NS_IMPL_ISUPPORTS2(DOMEventListener, nsIDOMEventListener, nsIDOMMouseListener) but gtk patform using autotools and .pc files that does not require to have hardcoded "content" in Makefile.
Created attachment 356304 [details] [diff] [review] updated patch I've updated patch according changes in trunk
Created attachment 356307 [details] [diff] [review] prev patch + minor cleaning
Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.