Closed Bug 472772 Opened 11 years ago Closed 11 years ago

Text in comboboxes aren't visible in dark themes with light textboxes

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: ventnor.bugzilla, Assigned: ventnor.bugzilla)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
In our cross-platform forms.css we re-use the colours of textboxes to theme our <select> elements. This is good historically, considering comboboxes and textboxes once used pretty much the same widget, and still turned out alright if the combo box and textbox had the same contrast.

But in dark themes with light textboxes (such as the very popular Dark Room theme that ships with Ubuntu) this causes problems because you end up with dark text on a dark combobox (since the text on a white textbox is dark). My plan is to introduce a new colour value for comboboxes and read GTK's values from that.

I also introduce the hover rule since the accessibility contrast theme completely switches colours when hovering a widget so we need to do that too.
Attachment #356106 - Flags: superreview?(roc)
Attachment #356106 - Flags: review?(roc)
Actually, the hover rule might be very bad for web compatibility as webpages could look yucky if the native colour is used on hover for all selects no matter how they're styled. roc, what do you think?
I'm noticing other problems by implementing hover. I should take it out.
Attached patch Patch 2Splinter Review
No hover rules to cause problems.
Attachment #356106 - Attachment is obsolete: true
Attachment #356117 - Flags: superreview?(roc)
Attachment #356117 - Flags: review?(roc)
Attachment #356106 - Flags: superreview?(roc)
Attachment #356106 - Flags: review?(roc)
Attachment #356117 - Flags: superreview?(roc)
Attachment #356117 - Flags: superreview+
Attachment #356117 - Flags: review?(roc)
Attachment #356117 - Flags: review+
Keywords: checkin-needed
Whiteboard: [needs landing]
Pushed http://hg.mozilla.org/mozilla-central/rev/79e8e0d20019
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.