472777 - Unittest builds should do a "building on <slave>" step

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Since the consolidation of unittests with the other build tasks it's good practise to check what a slave is doing before connecting to it (unittest results can get screwed up otherwise, eg focus problems). I've taken to checking the buildbot waterfall for currently running unittest tasks but it's slow because they don't do a "building on <slave>" step. If they did then it'd be a simple search over the page. (Obviously it would be better if buildbot showed which job a slave was doing on the buildslaves pages).

It would also help if all builders reported the slave as the first step, before any disk cleanup tasks which take time to complete.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

The change catlee did on the master's buildslaves page lets you see this info, as well as the history of what previous jobs were processed on that slave. Is that sufficient, or do you want this on the waterfall also?

Comment 2

[Phil Ringnalda (:philor)]

Having it wind up on the tinderbox waterfall would vastly increase the odds of people outside RelEng correctly diagnosing the difference between "this is an intermittent failure" and "this is a mittent failure when slave03 runs unit tests."

Comment 3

[[e-mail] (:bhearsum)]

I will do this.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: echo out the slave name at the start of a build

This is a straight copy of the step from dep/nightly/leak test builds.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 357653 [details] [diff] [review]
echo out the slave name at the start of a build

Checking in process/factory.py;
/cvsroot/mozilla/tools/buildbotcustom/process/factory.py,v  <--  factory.py
new revision: 1.81; previous revision: 1.80
done

Comment 6

[[e-mail] (:bhearsum)]

Master reconfig'ed for it.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Ah, I was thinking we could do this in the __init__ of MozillaBuildFactory, since that would could also make it the first thing in the tinderbox log. Serves me right for not mentioning it.