Closed Bug 472784 Opened 15 years ago Closed 15 years ago

Preview is horked

Categories

(mozilla.org Graveyard :: Server Operations, task)

x86
All
task
Not set
blocker

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: stephend, Assigned: oremj)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

Attached image Screenshot
Right now, preview is pretty borked.  It happens with Minefield, Shiretoko, and Firefox 3.0.5.

Error: missing ; before statement
Source File: https://preview.addons.mozilla.org/js/jquery.addons.min.js?19777
Line: 1, Column: 126
Source Code:
eval(function(E,A,F,B,D,C){D=function(G){return(G<A?"":D(parseInt(G/A)))+((G=G%A)>35?String.fromCharCode(G+29):G.toString(36))}get ;if(!"".replace(/^/,String)){while(F--){C[D(F)]=B[F]||D(F)}B=[function(G){return C[G]}get ];D=function(){return"\w+"}get ;F=

Error: $ is not defined
Source File: https://preview.addons.mozilla.org/en-US/firefox/
Line: 292

etc...
Preview's file:

https://preview.addons.mozilla.org/js/jquery.addons.min.js?19777

is completely different than what I have on my dev copy, what is on the live site, and what is in SVN.  How does that happen?  Preview used to run the build script on cron but that was turned off, so I'm not really sure how this would happen.

Of course, webdev can't even access staging so over to IT.  Can you give us the output of `svn status` from the root please?  And check if that cron job still runs?
Assignee: nobody → server-ops
Component: Public Pages → Server Operations
Product: addons.mozilla.org → mozilla.org
QA Contact: web-ui → mrz
Version: unspecified → other
http://web_info_demo.oremj.khan.mozilla.org/ <- contains svn info/status/diff

Cron jobs:
# preview AMO
0,20,40 * * * * root cd /data/php5/www/addons.mozilla.org-preview/bin ; php -f maintenance.php total
10,30,50 * * * * root cd /data/php5/www/addons.mozilla.org-preview/bin ; php -f maintenance.php weekly
5,25,45 * * * * root cd /data/php5/www/addons.mozilla.org-preview/bin ; php -f maintenance.php reviews
15,35,55 * * * * root cd /data/php5/www/addons.mozilla.org-preview/bin ; php -f maintenance.php ratings
12 0 * * * root cd /data/php5/www/addons.mozilla.org-preview/bin ; php -f maintenance.php gc
42 0 * * * root cd /data/php5/www/addons.mozilla.org-preview/bin ; php -f maintenance.php unconfirmed
12,32,52 * * * * root cd /data/php5/www/addons.mozilla.org-preview/bin ; php -f update-search-views.php

Which bug was the build script set up in?
15 * * * * root /usr/local/bin/update-amo-preview.sh

That's what you want.
Doh, I was greping for "addons".  The cron is running:
...
Jan  8 23:15:01 mradm02 crond[9103]: (root) CMD (/usr/local/bin/update-amo-preview.sh)
Jan  9 00:15:01 mradm02 crond[13184]: (root) CMD (/usr/local/bin/update-amo-preview.sh)
Jan  9 01:15:01 mradm02 crond[17260]: (root) CMD (/usr/local/bin/update-amo-preview.sh)
...
Contents of script:
# clean up the tree from build stuff
cd /data/php5/www/addons.mozilla.org-preview/bin
sh clean.sh > /dev/null

# update SVN
/usr/local/bin/svn-up.sh /data/php5/www/addons.mozilla.org-preview HEAD

# now rebuild the JS
cd /data/php5/www/addons.mozilla.org-preview/bin
python build.py /usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/jre/bin/java > /dev/null
Assignee: server-ops → oremj
The conclusion is that it should be running on preview but not on production, I guess that's another bug.  

As far as this bug, I need IT to figure out what's wrong since I can't get to the machines.  Running that script on my dev machines gets me what is in SVN, and since it's running in production, apparently it does the same there as well.  Only preview comes up with the odd output.  For the record khan is using java version 1.4.2 but I don't know if that matters.
A good first step would probably be removing the redirection to /dev/null
Output after removing /dev/null:

/usr/local/bin/update-amo-preview.sh
Cleaning Build Files
Done
Updating Revisions
Latest Tree Revision: 21541
CSS Revision: 21272
JS Revision: 19777
Concatenating JS
Minifying JS
Concatenating CSS
Minifying CSS
Compiling .po Files
Done.
Bumping this to critical.  QA can't verify bugs.
Severity: major → critical
How long do you think this has been broken? 5 weeks maybe?
(In reply to comment #10)
> How long do you think this has been broken? 5 weeks maybe?

No; we were all looking at preview over in bug 438713 as recently as 1/14; this Just Recently Broke (tm).
Except that I filed this on the 8th; hrm.  Makes me wonder what's in my tea!  *shrug* -- maybe broken that long; egg on my face, if so.
Bumping this to blocker.  QA still can't verify bugs.  Let me know if I can help here.
Severity: critical → blocker
mradm02, where the build script was being run, was using openjdk.  I've replaced openjdk with Sun's Java and it fixed the problem.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Verified FIXED; w00t!  (Thanks, oremj!)
Status: RESOLVED → VERIFIED
Product: mozilla.org → mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: