472802 - Can't change focused bookmark property with Enter in Properties dialogue

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Radek 'sysKin' Czyz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090108 Minefield/3.2a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090108 Minefield/3.2a1pre

Can't change bookmark name from Properties dialogue.


Reproducible: Always

Steps to Reproduce:
1. Find a bookmark (anywhere: menu, toolbar, Organise, sidebar)
2. Right-click on it, select Properties
3. Change name
4. Press Save

Actual Results:  
Name is not changed


Expected Results:  
Name is changed :)


All other Properties fields get saved correctly.

Works on current Shiretoko but fails on Minefield.

Comment 1

[Marco Bonardo [:mak]]

it's working for me...
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090108 Minefield/3.2a1pre

Comment 2

[Radek 'sysKin' Czyz]

Ugh, seems to be my fault.

it fails if you press enter in step 4, but works if you press Save.

Comment 3

[Marco Bonardo [:mak]]

oh ok, that makes sense

Comment 4

[Radek 'sysKin' Czyz]

OK a more detailed analysis: any field will save itself the moment it loses focus. So changing name and pressing tab button will make the name changed. Same applies to other fields.

Pressing Save also saves, because focus is transferred to Save button. To make things funnier, even pressing Cancel saves changes, and then undoes them.

But if you press enter, the field being edited never manages to lose focus and any changes to that field are not saved.

Comment 5

[Marco Bonardo [:mak]]

this is a regression from bug 462765, landed on trunk, not on shiretoko.

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch v1.0

i think that the editBookmarkOverlay itself should be more robust in saving changes when a caller uninit it, blurring the current focused element.

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 356158 [details] [diff] [review]
patch v1.0

canceling review request per irc, need to ensure focused element is a descendant of the panel.

Comment 9

[Marco Bonardo [:mak]]

Attachment: patch v2

i can't find a perf sensitive way of fixing this globally, so i'm going to fix for the only panel that has issues, document in this case is the window dialog, so there's no risk to blur something unrelated.
Notice to fix bug 473120 we need bug 462765, that has this regression, so ideally we should try to land this on trunk today, and push both to 3.1 branch before the freeze.

Comment 10

[Dietrich Ayala (:dietrich)]

Comment on attachment 356509 [details] [diff] [review]
patch v2

sounds reasonable, r=me.

Comment 11

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/c774155fb747

Comment 12

[Marco Bonardo [:mak]]

Comment on attachment 356509 [details] [diff] [review]
patch v2

asking approval, this is needed to fix a regression caused by a patch that was fixing a blocking regression.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 356509 [details] [diff] [review]
patch v2

a191=beltzner

Comment 15

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6de0371245ec

Comment 16

[Marco Bonardo [:mak]]

wrong changeset in comment 15, the correct one is:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8c25d416f9f9

Comment 17

[Aakash Desai [:aakashd]]

verified FIXED on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090331 Shiretoko/3.5b4pre ID:20090331041754

and on: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090331 Minefield/3.6a1pre ID:20090331044608

Comment 18

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv