Can't change focused bookmark property with Enter in Properties dialogue

VERIFIED FIXED in Firefox 3.6a1

Status

()

VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: syskin2, Assigned: mak)

Tracking

({regression, verified1.9.1})

unspecified
Firefox 3.6a1
x86
Windows Vista
regression, verified1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090108 Minefield/3.2a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090108 Minefield/3.2a1pre

Can't change bookmark name from Properties dialogue.


Reproducible: Always

Steps to Reproduce:
1. Find a bookmark (anywhere: menu, toolbar, Organise, sidebar)
2. Right-click on it, select Properties
3. Change name
4. Press Save

Actual Results:  
Name is not changed


Expected Results:  
Name is changed :)


All other Properties fields get saved correctly.

Works on current Shiretoko but fails on Minefield.

Updated

10 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
(Assignee)

Comment 1

10 years ago
it's working for me...
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090108 Minefield/3.2a1pre
(Reporter)

Comment 2

10 years ago
Ugh, seems to be my fault.

it fails if you press enter in step 4, but works if you press Save.
(Assignee)

Comment 3

10 years ago
oh ok, that makes sense
Summary: Can't change bookmark name from Properties dialogue → Can't change bookmark name from Properties dialogue pressing Enter
(Reporter)

Comment 4

10 years ago
OK a more detailed analysis: any field will save itself the moment it loses focus. So changing name and pressing tab button will make the name changed. Same applies to other fields.

Pressing Save also saves, because focus is transferred to Save button. To make things funnier, even pressing Cancel saves changes, and then undoes them.

But if you press enter, the field being edited never manages to lose focus and any changes to that field are not saved.
Summary: Can't change bookmark name from Properties dialogue pressing Enter → Can't change bookmark name from Properties dialogue
(Assignee)

Comment 5

10 years ago
this is a regression from bug 462765, landed on trunk, not on shiretoko.
Assignee: nobody → mak77
Blocks: 462765
Status: NEW → ASSIGNED
(Assignee)

Comment 6

10 years ago
Created attachment 356158 [details] [diff] [review]
patch v1.0

i think that the editBookmarkOverlay itself should be more robust in saving changes when a caller uninit it, blurring the current focused element.
Attachment #356158 - Flags: review?(dietrich)
(Assignee)

Updated

10 years ago
Summary: Can't change bookmark name from Properties dialogue → Can't change focused bookmark property with Enter in Properties dialogue
Attachment #356158 - Flags: review?(dietrich)
Comment on attachment 356158 [details] [diff] [review]
patch v1.0

canceling review request per irc, need to ensure focused element is a descendant of the panel.

Updated

10 years ago
Duplicate of this bug: 472936
(Assignee)

Comment 9

10 years ago
Created attachment 356509 [details] [diff] [review]
patch v2

i can't find a perf sensitive way of fixing this globally, so i'm going to fix for the only panel that has issues, document in this case is the window dialog, so there's no risk to blur something unrelated.
Notice to fix bug 473120 we need bug 462765, that has this regression, so ideally we should try to land this on trunk today, and push both to 3.1 branch before the freeze.
Attachment #356158 - Attachment is obsolete: true
Attachment #356509 - Flags: review?(dietrich)
Comment on attachment 356509 [details] [diff] [review]
patch v2

sounds reasonable, r=me.
Attachment #356509 - Flags: review?(dietrich) → review+
(Assignee)

Comment 11

10 years ago
http://hg.mozilla.org/mozilla-central/rev/c774155fb747
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
(Assignee)

Comment 12

10 years ago
Comment on attachment 356509 [details] [diff] [review]
patch v2

asking approval, this is needed to fix a regression caused by a patch that was fixing a blocking regression.
Attachment #356509 - Flags: approval1.9.1?
(Assignee)

Updated

10 years ago
Duplicate of this bug: 473491
Comment on attachment 356509 [details] [diff] [review]
patch v2

a191=beltzner
Attachment #356509 - Flags: approval1.9.1? → approval1.9.1+
verified FIXED on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090331 Shiretoko/3.5b4pre ID:20090331041754

and on: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090331 Minefield/3.6a1pre ID:20090331044608
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.