473038 - Hack around bug 456311 for Tb3

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Hackaround redux

Unless one of our lottery tickets wins, and we use the money to hire Donald Knuth and buy a time machine to give him enough time to learn Cocoa and Widget: Cocoa, Tb3 is going to ship with bug 456311 unfixed, so that on 10.4 every time you use a commandkey for an Edit menu function without first opening the menu it will both work and blare the system beep at you (and on 10.5 the menu won't flash, yeah, whatever).

Because that beeping's a nasty thing to do, but because we want to keep the awesome pressure of our trunk users on Widget: Cocoa to produce a fix, I'll push this hackaround (as originally seen in bug 382138, with the comment slightly altered) on the branch only, once we have a branch.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Man, I was really hoping to both get to play with a time machine and meet Knuth.

Comment 2

[Mark Banner (:standard8)]

We have a branch now (hint hint ;-) ).

Comment 3

[Phil Ringnalda (:philor)]

At work, and thus without a tree.

I have an amusing anecdote, though: Enn's post (http://enndeakin.wordpress.com/2009/10/24/command-updating-performance/) about command updating reminded me of bug 404232, which I'd forgotten all about, where Myk did a similar command updating hack, discovered that it breaks the Mac menu like ours does, and just ifdeffed it out for Mac, and then attached an image of perf graphs that seem to be saying it didn't really do anything much.

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/releases/comm-1.9.1/rev/62cf2beefde6