473120 - Hitting Escape in bookmark properties saves changes

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Chris Gadd]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-NZ; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-NZ; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2

Hitting the Escape key while editing the bookmark properties will save any changes.

Reproducible: Always

Steps to Reproduce:
1.Edit a bookmark from right clicking on bookmark toolbar or bookmarks menu entry.
2.Change some text (name or URL).
3.Hit ESC
Actual Results:  
Changes to bookmark properties are saved.

Expected Results:  
Changes should be ignored.

Tested in safe mode (addons/themes disabled).

Comment 1

[Dave Garrett]

Confirmed. (latest 3.1 on Linux)

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

asking blocking, due to regression

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

can anyone test trunk? could be fixed by patch in bug 462765 (landed on trunk), and i cannot reproduce on Win.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

indeed, i can reproduce on 1.9.1 branch, not on trunk, so my guess appears correct.

fixed on trunk by bug 462765, will be fixed on branch when that patch AND bug 472802 will get approval and land on branch. i'll try to do that before b3.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is a dataloss bug. Not everybody will notice that behavior instantly. Updating flags.

Comment 6

[Dietrich Ayala (:dietrich)]

blocking for dataloss.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Huh, dataloss is critical not major. Sorry.

Verified on trunk with:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090113 Minefield/3.2a1pre ID:20090113035246

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090113 Minefield/3.2a1pre ID:20090113020320

I believe its worth to have a separate testcase here beneath the one in bug 462765.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified on 1.9.1 with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090116 Shiretoko/3.1b3pre Ubiquity/0.1.4 ID:20090116020328

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090116 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090116035118

The following Litmus test already covers that regression:
https://litmus.mozilla.org/show_test.cgi?id=7460

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv