473142 - Recording a test for several windows at once doesn't build test

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090109 Shiretoko/3.1b3pre ID:20090109054324 and MozMill 1.0

Recording a test, where multiple windows are processed, the recorder doesn't build the test. Instead you will only see the fetched actions inside the editor.

For example:

click:: 3397748969
click:: 3397748969
click:: 3397755585
change:: 436460541
click:: 3397759736

I can reproduce it by running following steps:

1. Open MozMill and activate recorder
2. Click inside the browser window to focus e.g. the search field on google.com
3. Open the preferences window
4. Click a checkbox / radio button
5. Close preferences window
6. Click on Stop (curiously you have to do it twice)

With step 6 the tracked actions aren't converted to a working test. Instead following errors appear:

Error: e.evt.target.value is undefined
Source File: chrome://mozmill/content/rec.js
Line: 99

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMWindowInternal.length]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://mozmill/content/rec.js :: anonymous :: line 248"  data: no]

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Seems like that the recorder isn't stopped. Even the user hits the stop button. Further you can see that actions are getting added when opening the preferences window afterward and clicking the same checkbox / radio button again.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

I can confirm this bug and I think its quite critical since many tests in Calendar/Thunderbird involve multiple windows. Its also quite annoying since the editor window often receives extra text output I need to remove everytime after accidentally choosing a second window.

Comment 3

[Mikeal Rogers [:mikeal] (mrogers@)]

Henrik, is this bug still valid against trunk?

I can't seem to reproduce it.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's a bit more complicate and one more bug to fix. That definitely happens when you try to create a test by the help of the recorder a second time within a session:

1. Start recording.
2. Do some clicks and directly click stop recording
3. Click on the recorder menu again
4. No way to stop recorder

With step 2 the overlay isn't closed sometimes. You have a start button but it doesn't react. Closing the overlay manually and clicking the record menu item again, doesn't bring up the overlay. Means there is no way to stop recording. You should be able to reproduce this.

Comment 5

[Adam Christian]

This should be fixed, Committed revision 380.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Adam, can we also catch the issue on this bug that the recorder overlay doesn't get closed after stopping a test? I would expect that as a default behavior. See my above steps from comment 4. For me it happens after having recorded two sessions.

Comment 7

[Adam Christian]

The reason that the dialog stays open is if you want to stop, and then re-record. The close button calls the same stop function and closes the dialog, if that is the behavior you want you can use that button instead. I find myself re-recording tests a few times in which case the stop button closing the dialog would be very irritating.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oh my fault. Seems like I've accidentally hit the close button. Ok, looks good. Problem is fixed. Thanks!

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Somehow this bug is back with r398. It can be clearly reproduced with the following steps:

1. Open MozMill window
2. Press Cmd+D
3. Click the New Tab icon
4. Click the homepage button
5. Open the preferences window
6. Click on "use current pages" as my homepage button
7. Close preferences window
8. Stop recorder

After step 8 the recorded events aren't converted into a test. Further tries to start the recorder blows away the whole overlay and you aren't able to stop the recorder anymore. I've shown this bug to Clint.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Probably because of the following error?

Error: e.evt.target.value is undefined
Source File: chrome://mozmill/content/rec.js
Line: 99

Comment 11

[Adam Christian]

Mikeal this is in your cleanupEventsArray function.

Comment 12

[Mikeal Rogers [:mikeal] (mrogers@)]

This should fix that error, I hope it fixes the bug but I don't completely understand why this is happening so I don't know.

Committed revision 407.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With the steps in comment 9 it's still broken in r414. You should try it by yourself and you will see it immediately if it's really fixed. The steps are easy.

I still get the same error but with another code line:

Error: e.evt.target.value is undefined
Source File: chrome://mozmill/content/rec.js
Line: 107

Comment 14

[Mikeal Rogers [:mikeal] (mrogers@)]

The latest failure is on a new line later in the code, we made it past the first failure :)

Committed revision 417.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Wow, that's cool! I'm happy. No more reopenings. Works perfectly. Thanks Mikeal.