473194 - Hitting enter to edit recurring meetings doesn't work

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Pete]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.5) Gecko/2008120121 Firefox/3.0.5
Build Identifier: Lightning 1.x nightly build running under Thunderbird 3.0 b1

If I open a recurring meeting I get a pop up asking if I want to "Edit just this occurrence" or "Edit all occurrences".  Hitting enter should then open the highlighted option.  It does not and does not show an error.  The only way to select an option is to actually click it with the mouse.

Reproducible: Always

Steps to Reproduce:
1.Create a recurring meeting
2.Double click it
3.Hit enter
Actual Results:  
Nothing happens.

Expected Results:  
The meeting item should be opened.

Comment 1

[Stefan Sitter [:ssitter]]

Works for me using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090113 Calendar/1.0pre.

Comment 2

[Martin Schröder [:mschroeder]]

We need somebody with a Mac to possibly confirm this issue. -> qawanted

Comment 3

[Martin Schröder [:mschroeder]]

Confirmed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.4pre)
Gecko/20090915 Lightning/1.0pre Thunderbird/3.0b4 with Lightning nightly build
20091024.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This fixes it on mac, I'd appreciate if you could doublecheck it doesn't do any damage on your OS.

Comment 5

[Decathlon]

Comment on attachment 513153 [details] [diff] [review]
Fix - v1

(In reply to comment #4)

> This fixes it on mac, I'd appreciate if you could doublecheck it doesn't do any
> damage on your OS.

Actually, on WinXP, the dialog works better with the patch because the first button ("Edit just this occurrence") now loses the highlighted border when the focus goes on the other buttons (moving the focus with the tab or arrow keys). Without patch that button always has the highlighted border, even when it doesn't have the focus.
Lightning 0.9 has this behavior too.

The functioning is the same as before. The Enter and the space keys work with the highlighted button of the dialog. The arrow keys and the Tab key allow to move the highlighted button.
The cancel button deletes the dialog and the other two open the Edit Dialog.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/84a931bfd407>
-> FIXED

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/0f78a7deed63>
a=philipp