Closed Bug 473201 Opened 15 years ago Closed 15 years ago

config.rdf.tmpl flag_type should include group information

Categories

(Bugzilla :: Bugzilla-General, defect)

3.3.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.4

People

(Reporter: Frank, Assigned: Frank)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_6; de-de) AppleWebKit/525.27.1 (KHTML, like Gecko) Version/3.2.1 Safari/525.27.1
Build Identifier: 3.3.1

The information for grant_group and request_group should be included in the rdf output

Reproducible: Always
Attached patch patch, V1 (obsolete) — Splinter Review
Attachment #356568 - Flags: review?
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → 3.3.1
Attachment #356568 - Flags: review? → review-
Comment on attachment 356568 [details] [diff] [review]
patch, V1

Your patch works fine, but we don't want to leak group names to everybody. You should enclose these two lines in [% IF user.in_group("editcomponents") %].
Please update your patch asap; we freeze tomorrow.
Assignee: create-and-change → Frank
Status: UNCONFIRMED → ASSIGNED
Component: Creating/Changing Bugs → Bugzilla-General
Ever confirmed: true
Target Milestone: --- → Bugzilla 3.4
(In reply to comment #2)
> (From update of attachment 356568 [details] [diff] [review])
> Your patch works fine, but we don't want to leak group names to everybody. You
> should enclose these two lines in [% IF user.in_group("editcomponents") %].

OK, but then we can not use this to get the information that we need for Mylyn to know what values are legal for an flag.

This bug is releated to https://bugzilla.mozilla.org/show_bug.cgi?id=473220

For Mylyn see https://bugs.eclipse.org/bugs/show_bug.cgi?id=258712

Thoughts?
(In reply to comment #4)
> OK, but then we can not use this to get the information that we need for Mylyn
> to know what values are legal for an flag.

Well, when you call config.cgi, you also only have access to products you are allowed to see; you don't get all existing products. The same rule applies here: you can only get the information your credentials allow you to see.
Attached patch patch, V2Splinter Review
Attachment #356568 - Attachment is obsolete: true
Attachment #359455 - Flags: review?
Attachment #359455 - Flags: review? → review+
Comment on attachment 359455 [details] [diff] [review]
patch, V2

r=LpSolit. I will fix the indentation on checkin.
Flags: approval+
Checking in template/en/default/config.rdf.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/config.rdf.tmpl,v  <--  config.rdf.tmpl
new revision: 1.17; previous revision: 1.16
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: