Closed
Bug 473207
Opened 15 years ago
Closed 15 years ago
clean up after gnomestripe landing (and more)
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b2
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(2 files)
37.87 KB,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
8.22 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
Clean up the platform ifdefs that's not needed anymore.
Attachment #356572 -
Flags: review?(philringnalda)
Updated•15 years ago
|
Attachment #356572 -
Flags: review?(philringnalda) → review+
Assignee | ||
Comment 1•15 years ago
|
||
changeset: 1616:fb5a461cd100 http://hg.mozilla.org/comm-central/rev/fb5a461cd100 ->FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 2•15 years ago
|
||
editorOverlay.css seems to have been removed from qute is that right? Also, I'm fairly sure messenger.css no longer needs preprocessing in qute or gnomestripe.
Assignee | ||
Comment 3•15 years ago
|
||
Hm, the files I thought I removed are still there. Must have messed up with hg somehow. ! mail/themes/gnomestripe/mail/newMailAlertUnix.css ! mail/themes/qute/mail/compose/editorOverlay.css ! mail/themes/qute/mail/newMailAlertUnix.css Your right, should fix messenger.css preprocessing too.
Assignee: nobody → mkmelin+mozilla
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 4•15 years ago
|
||
Don't preprocess messenger.css, and get rid of the files i got rid of in the earlier patch, for real.
Attachment #357015 -
Flags: review?(bugzilla)
Comment 5•15 years ago
|
||
Comment on attachment 357015 [details] [diff] [review] proposed fix, part 2 editorOverlay.css is still referenced: http://mxr.mozilla.org/comm-central/search?string=editorOverlay.css&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=comm-central Are you sure its not required?
Assignee | ||
Comment 6•15 years ago
|
||
It was only added to get gtk icons for the compose window. Pinstripe doesn't have it either... and I haven't heard any complaints.
Comment 7•15 years ago
|
||
(In reply to comment #6) > It was only added to get gtk icons for the compose window. Pinstripe doesn't > have it either... and I haven't heard any complaints. Then I think we should be removing that reference.
Assignee | ||
Comment 8•15 years ago
|
||
Which ref is not needed? I'm just removing the editorOverlay.css qute copy. We still want it for gnomestripe.
Comment 9•15 years ago
|
||
Comment on attachment 357015 [details] [diff] [review] proposed fix, part 2 Sorry for the delay in getting to this.
Attachment #357015 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 10•15 years ago
|
||
changeset: 1760:7d5d886a43ed http://hg.mozilla.org/comm-central/rev/7d5d886a43ed
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•