473220 - Programmatic access to data from userprefs.cgi (XML, WebServices)

Status: RESOLVED WONTFIX

(Bugzilla :: User Accounts, enhancement)

Description

[Frank Becker]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_6; de-de) AppleWebKit/525.27.1 (KHTML, like Gecko) Version/3.2.1 Safari/525.27.1
Build Identifier: 3.3.1

to get the flags work for Mylyn we need information about the groups

1) see https://bugzilla.mozilla.org/show_bug.cgi?id=473201
2) userprefs only supports html (I create an possible patch for this enhancement)




Reproducible: Always

Comment 1

[Frank Becker]

Attachment: patch, V1

Comment 2

[Frédéric Buclin]

Comment on attachment 356582 [details] [diff] [review]
patch, V1

>+++ template/en/default/account/prefs/prefs.rdf.tmpl	2009-01-12 21:59:43.000000000 +0100
>@@ -0,0 +1,61 @@
>+
>+f this file are subject to the Mozilla Public

The template seems broken.


>+  #                 Frédéric Buclin <[e-mail]>

Are you using UTF8 in your text editor? My first name is completely broken. Also, I didn't write this template. You should have your own name in the contributor list instead.

Comment 3

[Max Kanat-Alexander]

Also, it would be better to work on exposing this information through the webservices interface. Also, RDF is not a good format, if you really do want to do this, just use some XML.

Comment 4

[Frank Becker]

Attachment: patch, V2

Now I use type xml and not rdf

Comment 5

[Frédéric Buclin]

Comment on attachment 359450 [details] [diff] [review]
patch, V2

>+++ template/en/default/account/prefs/prefs.xml.tmpl	2009-01-29 05:11:59.000000000 +0100

>+  # The Initial Developer of the Original Code is Netscape Communications

Really? I didn't know you were working for Netscape. ;)


>+     <user>
>+     <id>[% user.id FILTER html %]</id>
>+     <login_name>[% user.login_name FILTER html %]</login_name>
>+     <realname>[% user.realname FILTER html %]</realname>
>+     </user>

Please fix the indentation. Also, why using FILTER html instead of FILTER xml? Is there any reason for that?


>+     <has_bits>

has_bits?? Wouldn't "groups" or "permissions" be more explicit?


>+    <set_bits>

Same here.

Comment 6

[Frank Becker]

Attachment: Patch, V2

new version with corrections from comment#5

Sorry I copied the new file from an html template and did not change all the places.

Comment 7

[Frédéric Buclin]

Comment on attachment 361937 [details] [diff] [review]
Patch, V2

Sorry for taking so long to review this patch. I was busy with real work and the release of Bugzilla 3.4rc1.


>Index: template/en/default/list/list.rdf.tmpl

This template is unrelated to this bug. Please remove it.


>+++ template/en/default/account/prefs/prefs.xml.tmpl	2009-02-11 23:09:47.000000000 +0100

>+[%# The contents of this file are subject to the Mozilla Public
>+  # License Version 1.1 (the "License"); you may not use this file
>+  # except in compliance with the License. You may obtain a copy of
>+  # the License at http://www.mozilla.org/MPL/
>+  #
>+  # Software distributed under the License is distributed on an "AS
>+  # IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
>+  # implied. See the License for the specific language governing
>+  # rights and limitations under the License.
>+  #
>+  # Contributor(s): Frank Becker <[e-mail]>
>+  #
>+  #%]

Please copy and paste http://www.mozilla.org/MPL/boilerplate-1.1/mpl-sh to get the correct license block.


>+<prefs>
>+     <user>
>+       <id>[% user.id FILTER xml %]</id>

In templates, the indentation is only 2 characters, not 4.


>+                <description>[% bit_description.desc FILTER html_light %]</description>

You must use |FILTER xml| for the group description, else you let some HTML tags going through, which generates invalid XML documents.


>+                <description>[% bit_description.desc FILTER html_light %]</description>

Same here.

Otherwise, your patch looks good and works fine. Note that if you call ctype=xml with a tab different from tab=permissions, you still get your XML document, but with no data. Maybe should we rather reject it?

Comment 8

[Frank Becker]

Maybe that is no longer needed if we get bug#504937 fixed soon and change Mylyn to use the webservice.

Should I still fix this?

Comment 9

[Frédéric Buclin]

(In reply to comment #8)
> Maybe that is no longer needed if we get bug#504937 fixed soon and change Mylyn
> to use the webservice.
> 
> Should I still fix this?

If you are going to use WebService, then there is no need to implement this new XML interface to access user data, as we would have duplicated code. So marking as WONTFIX in favor of bug 504937.