473240 - talos try skips auto-reboot step if earlier buildbot factory step fails.

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[alice nodelman [:alice] [:anode]]

Unfortunately, if the browser crashes or cvs/graph server is down the talos factory never makes it to the auto-reboot step and thus fails to reboot post every test run.

Auto-rebooting should happen regardless of the the status of previous build steps.

Comment 1

[Chris Cooper [:coop] (he/him)]

catlee is working on an alwaysRun patch to buildbot core that would help here.

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #1)
> catlee is working on an alwaysRun patch to buildbot core that would help here.

/me agrees, and pushes bug over to catlee.

Comment 3

[Chris AtLee [:catlee]]

This is buildbot ticket #414: http://buildbot.net/trac/ticket/414

It's been accepted upstream, we should test this out in staging soon.

Comment 4

[Chris AtLee [:catlee]]

Attachment: Add alwaysRun support to buildbot

Comment 5

[Chris AtLee [:catlee]]

Attachment: Use alwaysRun=True for reboot step in perf-staging

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 358394 [details] [diff] [review]
Use alwaysRun=True for reboot step in perf-staging

Checking in perf-staging/perfrunner.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perf-staging/perfrunner.py,v  <--  perfrunner.py
new revision: 1.2; previous revision: 1.1
done

Comment 7

[alice nodelman [:alice] [:anode]]

This is still true for talos try, so updating summary to reflect that, of course talos try is also waiting to have auto-rebooting integrated into it so this will be blocked for a while.