Closed Bug 473334 Opened 11 years ago Closed 11 years ago

Unnecessary virtual on several methods in nsSVGSVGElement

Categories

(Core :: SVG, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: craig.topper, Assigned: craig.topper)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Makes the methods non virtual (obsolete) — Splinter Review
Several methods in nsSVGSVGElement have unnecessary NS_METHOD macros on them making them virtual. They don't come from an interface and nsSVGSVGElement has no derived classes.
Attachment #356671 - Flags: review?(jwatt)
Comment on attachment 356671 [details] [diff] [review]
Makes the methods non virtual

Thanks! This should have been done when we removed the nsISVGSVGElement interface and gave nsDOMSVGZoomEvent direct access to nsSVGSVGElement.
Attachment #356671 - Flags: review?(jwatt) → review+
Attachment #356671 - Flags: superreview?(roc)
Attachment #356671 - Flags: superreview?(roc) → superreview+
Keywords: checkin-needed
Attached patch Updated to tipSplinter Review
Attachment #356671 - Attachment is obsolete: true
Pushed http://hg.mozilla.org/mozilla-central/rev/f25cd7ccf8c4
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.