Status

()

defect
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: faaborg, Assigned: jboriss)

Tracking

({polish, verified1.9.1})

Trunk
Firefox 3.6a1
x86
Windows XP
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3.5 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [polish-easy] [polish-visual] [icon-shiretoko][icon-refresh][polish-p2])

Attachments

(2 attachments, 6 obsolete attachments)

This bug is for refreshing the icon we use for HTML (and other) documents on Windows XP.
Whiteboard: [polish-easy] [polish-visual] [icon-3.1]
Posted file New document.ico for Windows XP (obsolete) —
This file should replace the file at /other-licenses/branding/firefox/document.ico
Attachment #356683 - Flags: ui-review+
OS: Mac OS X → Windows XP
Comment on attachment 356683 [details]
New document.ico for Windows XP

This seems to be an 48*48px icon with a lot of padding, making the image 128*128px big. I don't think that's intentional, but please correct me if I'm wrong.
Attachment #356683 - Flags: review-
Keywords: checkin-needed
>This seems to be an 48*48px icon with a lot of padding, making the image
>128*128px big. I don't think that's intentional, but please correct me if I'm
>wrong.

I think that's because icons can not be larger than 48x48 on XP, but I'll make sure the icon file was generated correctly (I believe they are also missing 16 color versions, for all of those people still living in the early 90s).
(In reply to comment #1)
> Created an attachment (id=356683) [details]
> New document.ico for Windows XP
> 
> This file should replace the file at
> /other-licenses/branding/firefox/document.ico
If this is only for XP installer changes will be required to set the icon differently between XP and other versions of Windows and it will need to be added along with the existing icon.
Whiteboard: [polish-easy] [polish-visual] [icon-3.1] → [polish-easy] [polish-visual] [icon-3.1][icon-refresh]
Whiteboard: [polish-easy] [polish-visual] [icon-3.1][icon-refresh] → [polish-easy] [polish-visual] [icon-shiretoko][icon-refresh]
Summary: Refresh document.ico on XP → Refresh document.ico
Blocks: 492431
Are the 8-bit and 4-bit icons missing/needed?  I tried to generate some using Iconbuilder, which apparently didn't work - but if they are needed, either I can find some software to generate them, or perhaps someone can generate some based on the regular versions and then I can clean them up.  Please let me know, thanks.
I attached what should be the leftover icons, in a few formats:

- Vista 48x48, 32x32, and 16x16, in 8-bit and 4-bit, as PNGs and (attempted) icos (I was getting unknown errors, and this file may not work)
- Photoshop files with the above

That should be every needed document icon, so if anything else is needed please ping me or comment here.
Posted file Remaining document icons: 48x48 OSX (obsolete) —
Remaining documnet icons: 

- 48x48 OSX icon
- Photoshop & iso file with the above
Comment on attachment 382367 [details]
Remaining documnet icons: 8-bit and 4-bit Vista

Need a single .ico file for windows.
Attachment #382367 - Flags: ui-review-
Comment on attachment 382369 [details]
Remaining document icons: 48x48 OSX

OS X files need to be grouped into a single .icns file and posted to bug 473341
Attachment #382369 - Flags: ui-review-
Sorry my mistake, we are now using bug 496734 for the .icns OS X icon
Posted file .ico for Vista (obsolete) —
Attaching .ico for Vista
Posted file .icns for OSX (obsolete) —
Attaching .icns for OSX
Requesting blocking: the old Firefox logo needs to get updated now that we have deployed the other branding images.  Note that the files attached will break on Windows 2000, I'll work on new ones.
Flags: blocking-firefox3.5?
Comment on attachment 382434 [details]
.ico for Vista

need to remove the 128x128 for Vista or we break on windows 2000
Attachment #382434 - Flags: ui-review-
Attachment #382435 - Attachment is obsolete: true
Flags: blocking-firefox3.5? → blocking-firefox3.5+
Attachment #356683 - Attachment is obsolete: true
Attachment #382367 - Attachment is obsolete: true
Attachment #382369 - Attachment is obsolete: true
Attachment #382434 - Attachment is obsolete: true
I tested the .ico file out on XP, Vista and 2000.  Similar to bug 497333, the inclusion of a 128x128 resolution caused the file not to render at all on 2000.  Details are here:

https://bugzilla.mozilla.org/show_bug.cgi?id=497333#c21
Boriss: how are you doing the image resize for these?  The pixel hinting seems a little off.

To the left in this image is a smaller version of the Firefox icon I created for linux.  The process I used was:

-started from one size up (32x32)
-used "bicubic sharper" for the resampling
-tried to keep the canvas sizes even numbers, so 1 pixel doesn't get split across two

We may also want to cut the shadows on the logo for everything but the 256x256, since we already have a nice gradient on the page itself.
Assignee: nobody → jboriss
Attaching .ico file without the 128x128 icon.  This doesn't address faaborg's last comment, which I'll go through now, but at least there's now one that doesn't break the universe.
This is what that .ico file looks like in context on Windows 7:

http://people.mozilla.org/~beltzner/images/document-in-context.png
Adding a new version of the Vista icon without the 128x128 icon - reduced shadows per faaborg's comment.
Attachment #382763 - Attachment is obsolete: true
Verified fixed on trunk (code checkin) and 1.9.1 with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1) Gecko/20090612 Firefox/3.5 (.NET CLR 3.5.30729) ID:20090612072440
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 3.6a1
This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.
Whiteboard: [polish-easy] [polish-visual] [icon-shiretoko][icon-refresh] → [polish-easy] [polish-visual] [icon-shiretoko][icon-refresh][polish-p2]
You need to log in before you can comment on or make changes to this bug.