Closed Bug 473347 Opened 11 years ago Closed 11 years ago

nsSVGLength2 DOM tearoffs can receive NaNs and infinity as inputs

Categories

(Core :: SVG, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: craig.topper, Assigned: craig.topper)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Need to ensure that the inputs to the DOM tearoffs are finite. This was previously done for other SVG DOM classes for bug 369418.
Attachment #356686 - Flags: review?(jwatt)
Attachment #356686 - Flags: superreview?(roc)
Attachment #356686 - Flags: review?(jwatt)
Attachment #356686 - Flags: review+
Comment on attachment 356686 [details] [diff] [review]
Patch to add FINITE checks

Drat! I systematically went through all the SVG DOM interfaces looking for float, but obviously I forgot when I got to SVGLength that there were two implementations of it. (SVGNumber is okay.)

Good catch!
Attachment #356686 - Flags: superreview?(roc) → superreview+
We should get this on branch.

Also, a mochitest would be good.
Flags: blocking1.9.1+
Keywords: checkin-needed
Priority: -- → P3
Whiteboard: [needs landing]
Pushed http://hg.mozilla.org/mozilla-central/rev/7e7fcd60836c
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing] → [needs 191 landing]
You need to log in before you can comment on or make changes to this bug.