47343 - reorder the view:character coding menu according to the spec

Status: RESOLVED WONTFIX

(Core :: Internationalization, defect, P3)

Description

[Frank Tang]

We need to reorder the View:Character Coding submenu according to the spec
We should have 4 sections
[Auto Detect]
[Charsets]
More>
Customize...

This is the A2 task per ftang/cata meeting. It should include bug 37132,38290.
It depending on task [ can we specify the ordre of menu item from rdf data 
source]. The estimation from cata is BEST:2 days/MOSTLIKELY 6 days/WORST:12 days

Comment 1

[Frank Tang]

nsbeta3

Comment 2

[Frank Tang]

Mark as nsbeta3+.

Comment 3

[Frank Tang]

mark it as P4

Comment 4

[cata]

The work for this bug consists of 2 parts:
1) Figure out how to actually specify that desired order
2) Fix various functionality that assumes the current order in menu

Comment 5

[cata]

I'm working on 1) now. It is rather tricky because this interaction and mixure 
of: XUL and RDF. The solution should come from the fix to the related bug 
#20795.

Comment 6

[cata]

Ok, the final comment in bug 20795 is a bit criptic and incomplete. But thanks 
to the usage example from 
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigator
Overlay.xul#260 I finally got it: you have to use sortStaticsLast="true" on the 
popup *and* sortDirection="ascending" on the menu!!! 

But now I have 2 problems:
1.1) I am getting some weird assertions
1.2) looks like all you can do with this ordering is to have all statics at the 
end or at the beginning; what about statics, then genrated, the statics again?!

Investigating...

Comment 7

[cata]

Damn, the assertions represent a bigger problem than I thought. I cannot 
continue until that issue gets solved. Bug #51094 has been filled. 

Comment 8

[cata]

*** Bug 38290 has been marked as a duplicate of this bug. ***

Comment 9

[cata]

Notice that I marked bug #38290 as a duplicate of this bug. What does that mean 
is that after reordering the menu, I have to go and check/change the separators 
in the menu. Do not rely only on visual feedback, that can be deceiving. Go step 
through the code.

Comment 10

[Frank Tang]

Peter Trudelle minus 48774 . I suggest we check in what we have now (so we will 
have a duplicate Customize menu in window and Linux) and let hyatt deal with 
that issue later. 

Comment 11

[Frank Tang]

I take back my suggestion. I get assertion as cata predict. we have no way to 
fix this issue unless hyatt fix 48774

Comment 12

[Frank Tang]

I put the proposed new mozilla/xpfe/global/resources/content/charsetOverlay.xul 
under http://warp/u/ftang/tmp/charsetOverlay.xul

You can see we show two "Customize... " menu item in the View:Character Coding 
menu.

Comment 13

[Frank Tang]

Change to P3. 

Comment 14

[Frank Tang]

change the status.

Comment 15

[Peter Trudelle]

We'll reconsider spending Pink's, Hyatt's and RJC's precious time fixing this
obscure feature in our last few days before zarro boogs, provided that you
reconsider working around by changing the order of menu items to something that
works, which would be trivial.  If we can't agree, you can always appeal to PDT.

Comment 16

[Frank Tang]

after talk to pinkerton and momoi, we decide to withdraw the reorder request. I 
will mark this bug future now.

Comment 17

[Frank Tang]

move all cata's bug to ftang

Comment 18

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 19

[Frank Tang]

remove status whiteboard

Comment 20

[Mike Cowperthwaite]

See my new bug 253575.

Comment 21

[Jungshik Shin]

Neil, can you see what's involved here? Is it now possible to make the change
talked about here? 

Comment 22

[[e-mail]]

CCing some guys who might know...

Comment 23

[Eyal Rozenberg]

Can someone please explain what exactly is supposed to be changed into what? I'm
looking at the View|Character Encodings menu and I'm seeing AutoDetect, More,
Customize and several charsets. What is 'the spec'? And anyway, why not close
this bug and simply fix bug 253575 ?

Comment 24

[Frank Tang]

what a hack. I have not touch mozilla code for 2 years. I didn't read these bugs
for 2 years. And they are still there. Just close them as won't fix to clean up.

Comment 25

[Travis Chase]

Mass Re-assinging Frank Tangs old bugs that he closed won't fix and had to be
re-open. Spam is his fault not my own

Comment 26

[Biju]

Just a doubt....

Whether languages from "SE & SW Asian" are of second class ?

As they are crammed into one menu item,
When "East Asian" and "Middle Eastern" get separate entries
So do "West European" and "East European"

see Attachment #243068 [details] to Bug #205767 

We need a complete rearrange of the sub-menus too

Comment 27

[Anne (:annevk)]

This is obsolete with bug 910192 and others.

Comment 28

[Gordon P. Hemsley [:GPHemsley]]

(In reply to Anne (:annevk) from comment #27)
> This is obsolete with bug 910192 and others.

I think WONTFIX is more appropriate than INCOMPLETE.