Closed
Bug 473447
Opened 16 years ago
Closed 16 years ago
F1 on nix/win and cmd+? on mac in Debug prefpane opens a blank Help window
Categories
(SeaMonkey :: Preferences, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stefanh, Assigned: mnyromyr)
References
Details
Attachments
(1 file)
|
2.33 KB,
patch
|
stefanh
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Since bug 319850 landed on 1.9.1, a dialogHelp event is fired when you press F1/cmd+? in the Help window. Because of this, and that the OpenHelp method in prefwindow.xml doesn't check if we have a topic/or HelpURI, pressing the key combo in the Debug pane results in a blank Help window.
|
Assignee | |
Comment 1•16 years ago
|
||
While we may accept a missing topic, opening help without an URI where to get the help content from makes no sense. (Until 319850, this didn't matter, because no dialoghelp events got generated without clicking a help button.) I also took the chance and corrected mconnor's styling violations. :-P
Assignee: nobody → mnyromyr
Attachment #356829 -
Flags: superreview?(neil)
Attachment #356829 -
Flags: review?(stefanh)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 356829 [details] [diff] [review] ignore help requests without URI > <method name="openHelp"> > <parameter name="topic"/> > <parameter name="helpFileURI"/> > <body> > <
|
Reporter | |
Comment 3•16 years ago
|
||
Comment on attachment 356829 [details] [diff] [review] ignore help requests without URI If there's no topic, but a helpFileURI we'll just open the help start page, right? I wonder if we want that, so maybe you should check the topic as well...
|
|
Reporter | |
Updated•16 years ago
|
Attachment #356829 -
Flags: review?(stefanh) → review+
|
|
Reporter | |
Comment 4•16 years ago
|
||
Comment on attachment 356829 [details] [diff] [review] ignore help requests without URI > If there's no topic, but a helpFileURI we'll just open the help start page, > so maybe you should check the topic as > well... Yes, r=me with topic check and the missing ";". You'll need to update the comment, of course.
|
|
Assignee | |
Comment 5•16 years ago
|
||
(In reply to comment #2) > >+ // Empty help windows are not helpful... > >+ if (!helpFileURI) > Shouldn't we check the topic too? I really don't think we should. (In reply to comment #3) > If there's no topic, but a helpFileURI we'll just open the help start page, > right? I wonder if we want that, so maybe you should check the topic as > well... Why should we not want that? If you don't specify a specific topic, you should end up at the help system main page, which is "Welcome to SeaMonkey Help". I really don't see why we should enforce a topic...
|
|
Reporter | |
Comment 6•16 years ago
|
||
In bug 473444, I made the dialoghelp event only fire if you hit the key combo in a prefwindow with a (visible and not disabled) help button.
|
|
Assignee | |
Comment 7•16 years ago
|
||
> In bug 473444, I made the dialoghelp event only fire if you hit the key combo > in a prefwindow with a (visible and not disabled) help button. I think the url check makes still sense; landed this on trunk without the topic check (as per IRC) as <http://hg.mozilla.org/comm-central/rev/13557e287fe6>.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•