473529 - Archives folder doesn't use localized name in L10n builds

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Vlado Valastiak [:wladow]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1b3pre) Gecko/20090113 Shredder/3.0b2pre

Archives folder is created with default en-US name in L10n builds. Tested with several locales. Should use localized name instead.

Comment 1

[Stefan Plewako [:stef]]

It remains not localized after app restart?

Comment 2

[Mark Banner (:standard8)]

Did you checked that those localisations have had time to include the appropriate string?

AFAICT this is done in exactly the same way as the other special folders.

Comment 3

[Vlado Valastiak [:wladow]]

(In reply to comment #1)
> It remains not localized after app restart?
yes

(In reply to comment #2)
> Did you checked that those localisations have had time to include the
> appropriate string?
of course, sk and cs are good candidates for testing here, both with archivesFolderName included 

> AFAICT this is done in exactly the same way as the other special folders.
...and those are labeled correctly with localized strings

After a little investigation, it seems it does not work for POP3 accounts. I've tried it with my Gmail account - folder name was correctly localized when I used IMAP, but stayed in English when I used POP3 account.
And I don't see any related entry in Error Console.

Comment 4

[Nomis101]

The new Archives folder isn't also localized in my german Mac build of Thunderbird. It's named "Archives" instead of "Archiv" (or whatever the localizer desides for it).
Is it possible to rename this folder with an entry into the user.js?

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> Is it possible to rename this folder with an entry into the user.js?

Unlikely. The proper fix would be to fix this bug. Putting on the blocking radar - new feature so I think it should be localized correctly.

I have some ideas about how we may be able to fix this.

Comment 6

[Mark Banner (:standard8)]

Attachment: The fix

Sprinkle some more Archive flag checks around the system - basically the local (i.e. pop, local folders) archive folders weren't being treated as special folders and weren't having the flags set at the right times, hence not picking up the special folder names.

Comment 7

[Mark Banner (:standard8)]

Patch checked in: http://hg.mozilla.org/comm-central/rev/b3045b2abbb0

Comment 8

[Vlado Valastiak [:wladow]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1b3pre) Gecko/20090125 Shredder/3.0b2pre

Partially works now: the folder is still created with en-US label, but gets a proper localized label after the app is restarted. Reopening, pls close it if this is expected behaviour, but I think it shouldn't be.

Comment 9

[David :Bienvenu]

that is the expected behavior, though not the desired behavior. I believe there's a bug open for this problem in general with special folders we create. If so, this should be re-closed.

Comment 10

[Vlado Valastiak [:wladow]]

Ah, right, bug 467527. Re-closing.