47360 - full page plugins are not destroyed properly and leak

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[sean echevarria]

Full page plugins get added to the ActivePlugin list (nsPluginHostImpl.cpp) but
can't be removed.
Caching of full page plugin instances turns into a bottomless pit - instances
are not recorded as stopped, therefore they can never be removed until app
shutdown. Even if they were properly marked as stopped, they couldn't be reused
since the pluginViewer calls Destroy() on them.
Only nsActivePlugin::~nsActivePlugin() should call a plugin's Destroy() method.

The following line in
http://lxr.mozilla.org/seamonkey/source/modules/plugin/nglsrc/nsPluginViewer.cpp#741
 mInstance->Destroy();
should be removed and replaced with a call to nsPluginHostImpl::StopPluginInstance.

Comment 1

[sean echevarria]

nominating nsbeta3

Comment 2

[sean echevarria]

Attachment: patch with proposed fix

Comment 3

[sean echevarria]

added patch keyword

Comment 4

[Marc Attinasi]

Another nice patch, thanks sean!

Andrei, could you evaluate the change and either apply the patch or explain why 
we cannot accept it.

Comment 5

[av (gone)]

This change touches very delicate thing and is probably right. We have some 
problems with stop/destroy sequence. I'll check it out and see what implications 
are.

Comment 6

[av (gone)]

OK, this is slightly different from what I originally thought. Looks good. 
Checked in.

Comment 7

[shrirang khanzode]

verified tha that the requiredd changes are in.