Closed
Bug 473626
Opened 17 years ago
Closed 17 years ago
Traits-Caching code doesn't handle sparse slot layout
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stejohns, Assigned: stejohns)
Details
Attachments
(1 file)
|
881 bytes,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
It was formerly legal for an ABC/SWF to omit the TRAIT_Slot information for a slot; these slots would be of type * and have space allocated at the end of the instance. This code got lost in the Traits Caching rewrite. Patch restores it.
Attachment #356996 -
Flags: review?(edwsmith)
|
||
Comment 1•17 years ago
|
||
this can only be done for slots that are < the max declared slot #, correct? it should still be illegal for OP_get/setslot to reference a slot beyond the end of the instance.
|
|
Assignee | |
Comment 2•17 years ago
|
||
(In reply to comment #1)
> this can only be done for slots that are < the max declared slot #, correct?
correct
> it
> should still be illegal for OP_get/setslot to reference a slot beyond the end
> of the instance.
yep, and verifier should handle that.
|
|
||
Updated•17 years ago
|
Attachment #356996 -
Flags: review?(edwsmith) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
pushed to redux as changeset: 1297:6335b2edae6c
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•16 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•