473716 - Total download count occasionally shows up as zero

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wladimir Palant]

I added a new extension three days ago. The download count is low but it is being downloaded. For such a new extension "weekly downloads" and "total downloads" should be the same. Yet, when I checked https://addons.mozilla.org/en-US/firefox/addon/10345 yesterday I saw the correct weekly download count but zero downloads in total. This disappeared shortly afterward when the page got updated, now it shows correct numbers. Today I wanted to look at the statistics dashboard (https://addons.mozilla.org/en-US/statistics/addon/10345) - and this time it showed zero total downloads and "we don't have any data for this extension". All the other values were correct, and of course yesterday the statistics dashboard was showing the data correctly. Logging in didn't change anything. Again, after something like half an hour the issue disappeared and now it shows 144 total downloads (same as weekly downloads).

Comment 1

[Wladimir Palant]

Hm, now https://addons.mozilla.org/en-US/firefox/addon/10345 shows "0  weekly downloads" while the total downloads are correct. Again, logging in doesn't change anything.

Comment 2

[Wil Clouser [:clouserw]]

Since I'm waist deep in stats already I'll have a look at this too

Comment 3

[Dave Garrett]

Sounds like bug 426467.

Comment 4

[Wladimir Palant]

Yes, certainly sounds like it. But bug 426467 is WORKSFORME - this one certainly isn't (yet?).

Comment 5

[Wil Clouser [:clouserw]]

Haha, not yet. ;)

(I haven't reproduced this yet, for what it's worth)

Comment 6

[Wladimir Palant]

Attachment: Screenshot

I made a screenshot this time. Checked the page shortly after I uploaded a new version - and weekly downloads count shows up as zero (page is cached, still shows the old version).

Comment 7

[Wladimir Palant]

Attachment: Another screenshot

The page got updated yet the glitch in download counts remains.

Comment 8

[Wladimir Palant]

Just reloaded the page again and now it shows "154  weekly downloads".

Comment 9

[Dave Garrett]

Seeing as Wil is looking into things over here I'll note this here instead of reviving bug 426467 or filing another.

Flagfox's public page currently lists 78,035 weekly downloads and a whopping 119 total downloads. The stats page currently says 79,927 weekly downloads and 4,382,867 total downloads.

Comment 10

[Wladimir Palant]

Attachment: Yes another screenshot

One more screenshot - this time total downloads are zero whereas weekly downloads are correct.

Comment 11

[Dave Garrett]

We do believe you without the need for another screenshot.  ;)

Comment 12

[Wladimir Palant]

Just to show that both values have occasional and independent glitches - and put a timestamp on those.

Comment 13

[Wladimir Palant]

"zero total downloads" issue is stable right now, both in statistics dashboard and in the add-on listing - maybe caused by the log processing script?

Comment 14

[Wil Clouser [:clouserw]]

So, when the totaling script runs it does:

- set all download counts to zero
- total all add-ons
- update download counts

It sounds like you're hitting the page between step 1 and 3.  I don't know why step 1 even exists though.

Comment 15

[Wil Clouser [:clouserw]]

Attachment: don't reset the numbers

Comment 16

[Michael Morgan [:morgamic]]

Comment on attachment 361535 [details] [diff] [review]
don't reset the numbers

Don't know why the zeroing exists either.  Seems that doing this way makes it less fault tolerant as well.  So... I'm all for this - makes sense.

Comment 17

[Wil Clouser [:clouserw]]

Thanks, in r22123.  I'm calling this fixed and dropping it in the 5.0.2 milestone which goes out next week.

Comment 19

[Wladimir Palant]

I see "0  weekly downloads" for Adblock Plus right now. This was supposed to be fixed in production, reopening.

Comment 20

[Nick Nguyen [:osunick]]

It's looking OK for me now, are you still seeing this?

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

https://addons.mozilla.org/en-US/firefox/addon/1865 seems fine to me too.

Comment 22

[Wladimir Palant]

As usually, this issue only stays for one hour (until the cache expires). Right now it is fine for me again.

Comment 23

[Dave Garrett]

Attachment: zero weekly downloads in the middle of the top downloads list

Here's a screenshot of a new odd one I just saw. Right in the middle of the "popular" list, which lists by weekly downloads, I see an add-on who says it has 0 weekly downloads. The add-on's page itself shows correctly.

Comment 24

[Wil Clouser [:clouserw]]

Attachment: fix weekly counts

Weekly counts suffer the same problems totals did.  This patch is slower but avoids the blanket reset and speed isn't a big deal in this case anyway.

Comment 25

[Fred Wenzel [:wenzel]]

(In reply to comment #24)
> Weekly counts suffer the same problems totals did.  This patch is slower but
> avoids the blanket reset and speed isn't a big deal in this case anyway.

Why do we not do that as a single SQL command? Seems to me like the whole looping through arrays is rather clumsy?

Comment 26

[Wil Clouser [:clouserw]]

Comment on attachment 368026 [details] [diff] [review]
fix weekly counts

morgamic is out today and wenzel has grand ideas so r? to wenzel. :)

Comment 27

[Fred Wenzel [:wenzel]]

Comment on attachment 368026 [details] [diff] [review]
fix weekly counts

faaantastic. This only runs nightly, right? In that case I don't think the loops are a big deal.

Comment 28

[Wil Clouser [:clouserw]]

Thanks, r24168.  Hopefully this stays closed this time. :)  This code will be live Thursday night.

Comment 29

[Stephen Donner [:stephend] Not actively reading bugmail]

I think this is going to be hard to test on preview, since its DB is an older prod dump -- when was it last taken?  Right now, I'm seeing a lot of "0 weekly downloads".

Comment 30

[Dave Garrett]

Looks like the last sync was on 2008-11-14 (bug 464829). Preview always has "0 weekly downloads"; it has separate stats. It has gotten a bit stale, so filing another resync request bug might be a good idea.

Comment 31

[Dave Garrett]

Has this been pushed to production?

Comment 32

[Wil Clouser [:clouserw]]

Yes