473721 - operationLimit assertion failure on OS X

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Robert Sayre]

Assertion failure: operationLimit <= JS_MAX_OPERATION_LIMIT, at /builds/moz2_slave/mozilla-central-macosx-debug/build/js/src/jsapi.cpp:5272

I hit this when I merged to m-c on the leak test box.

Comment 1

[Robert Sayre]

js_InitOperationLimit sets this to JS_MAX_OPERATION_LIMIT + 1, which makes this look wrong:

> JS_SetOperationLimit(cx, JS_GetOperationLimit(origCx));

Comment 2

[Robert Sayre]

I wallpapered this for now:

http://hg.mozilla.org/mozilla-central/rev/562d8990f33a

Comment 3

[Igor Bukanov]

This is a regression from the bug 472702.

Comment 4

[Igor Bukanov]

Attachment: fix v1

My patch for the bug 472702 initializes JSContext.operationLimit to JS_MAX_OPERATION_LIMIT + 1 to detect if the embedding was ever set operation limit for JSContext instance explicitly. This is used by jstracer.cpp not to generate the code to update JSContext.operationCount when the limit is not set assuming that an application will use a separated thread or signals to set JSContext.operationCount to 0.

But I forgot in JS_GetOperationLimit to return JS_MAX_OPERATION_LIMIT, not JS_MAX_OPERATION_LIMIT + 1, so application can freely continue to use JS_(Get|Set)OperationLimit without surprises.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 357150 [details] [diff] [review]
fix v1

Don't forget to back out sayrer's wallpaper from comment 2 out when you check this in! Thanks.

Comment 6

[Igor Bukanov]

landed to tm - http://hg.mozilla.org/tracemonkey/rev/293624178003

Comment 7

[Igor Bukanov]

(In reply to comment #5)
> (From update of attachment 357150 [details] [diff] [review])
> Don't forget to back out sayrer's wallpaper from comment 2 out when you check
> this in! Thanks.

Done - http://hg.mozilla.org/tracemonkey/rev/90bdc10e0c83

Comment 9

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/293624178003

Comment 10

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9cd0940a9cf2