If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Bad return value in nsDOMStorage::CacheStoragePermissions()

RESOLVED FIXED

Status

()

Core
DOM
P2
normal
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

({fixed1.9.1})

unspecified
fixed1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 357126 [details] [diff] [review]
fix

Taras' tool found a dumb mistake in the patch from bug 458091, returning an nsresult where we should be returning a bool.
Attachment #357126 - Flags: superreview?(bzbarsky)
Attachment #357126 - Flags: review?(bzbarsky)
Attachment #357126 - Flags: approval1.9.1?
Attachment #357126 - Flags: superreview?(bzbarsky)
Attachment #357126 - Flags: superreview+
Attachment #357126 - Flags: review?(bzbarsky)
Attachment #357126 - Flags: review+
(Assignee)

Comment 1

9 years ago
http://hg.mozilla.org/mozilla-central/rev/9b5a61f187f1
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: blocking1.9.1?
Resolution: --- → FIXED

Updated

9 years ago
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2

Updated

9 years ago
Attachment #357126 - Flags: approval1.9.1?
Comment on attachment 357126 [details] [diff] [review]
fix

This is a blocker, doesn't need approval. dcamp, can you land this on the branch when you get a chance?
jst, bz: can one of you guys land this for dcamp?
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ba76edffc635
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.