Closed Bug 473739 Opened 11 years ago Closed 11 years ago

Bad return value in nsDOMStorage::CacheStoragePermissions()

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Attached patch fixSplinter Review
Taras' tool found a dumb mistake in the patch from bug 458091, returning an nsresult where we should be returning a bool.
Attachment #357126 - Flags: superreview?(bzbarsky)
Attachment #357126 - Flags: review?(bzbarsky)
Attachment #357126 - Flags: approval1.9.1?
Attachment #357126 - Flags: superreview?(bzbarsky)
Attachment #357126 - Flags: superreview+
Attachment #357126 - Flags: review?(bzbarsky)
Attachment #357126 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/9b5a61f187f1
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: blocking1.9.1?
Resolution: --- → FIXED
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Attachment #357126 - Flags: approval1.9.1?
Comment on attachment 357126 [details] [diff] [review]
fix

This is a blocker, doesn't need approval. dcamp, can you land this on the branch when you get a chance?
jst, bz: can one of you guys land this for dcamp?
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.