Closed Bug 473781 Opened 15 years ago Closed 15 years ago

Changes in "Junk Settings" are not permanent

Categories

(Thunderbird :: Account Manager, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: Nomis101, Assigned: jcranmer)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_6; de-de) AppleWebKit/528.10+ (KHTML, like Gecko) Version/3.2.1 Safari/525.27.1
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090115 Shredder/3.0b2pre

If I change the addressbook under "Do not mark mail as junk if the sender is in:" and click OK, this changes are not stored. 

Reproducible: Always

Steps to Reproduce:
1. Choose: Tools --> Account Settings --> Junk Settings
2. Make any changes under "Do not mark mail as junk if the sender is in:" and click OK.
3. Than look at the same Junk Settings one more time
Actual Results:  
The changes you have made are lost

Expected Results:  
It should store the changes you have made

I alos have this issue in TB 3.1a1pre
I am also seeing this, and have traced it as a regression from bug 435775. Essentially, none of the attributes in the junk settings pane are being saved. I backed out the patch from bug 435775, and the problem went away.

This is a serious issue that makes the junk filter unusable, so I think it should block TB beta 2.

As to reporter's comment "I also have this issue in TB 3.1a1pre" I fixed a similar bug many months ago, so it is possible that earlier he was seeing the prior problem.
Blocks: 435775
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-thunderbird3?
Target Milestone: --- → Thunderbird 3.0b2
(In reply to comment #1)
> As to reporter's comment "I also have this issue in TB 3.1a1pre" I fixed a
> similar bug many months ago, so it is possible that earlier he was seeing the
> prior problem.

3.1a1pre are the new "trunk" builds - not 3.0a1pre which were ages ago...
Sounds like a blocker.
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Attached patch Patch, version 1 (obsolete) — Splinter Review
This should fix the issue...
Assignee: nobody → Pidgeot18
Status: NEW → ASSIGNED
Attachment #357686 - Flags: superreview?(neil)
Attachment #357686 - Flags: review?(neil)
Attached patch Patch, version 2Splinter Review
I accidentally tested the wrong effect... :-(
Attachment #357686 - Attachment is obsolete: true
Attachment #357693 - Flags: superreview?(neil)
Attachment #357693 - Flags: review?(neil)
Attachment #357686 - Flags: superreview?(neil)
Attachment #357686 - Flags: review?(neil)
Attachment #357693 - Flags: superreview?(neil)
Attachment #357693 - Flags: superreview+
Attachment #357693 - Flags: review?(neil)
Attachment #357693 - Flags: review+
Pushed as changeset d58b5abb3fbc.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
(In reply to comment #5)
> Created an attachment (id=357693) [details]
> Patch, version 2

I've tested this patch in an 3.1a1pre build and it fixed the issue for me. So
it should also fix it in 3.0b2, but I haven't tested this.
Bug https://bugzilla.mozilla.org/show_bug.cgi?id=457269 seems to be a duplicate of the current one. I hope is fixed as well.
OS: Mac OS X → All
Hardware: x86 → All
(In reply to comment #8)
> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=457269 seems to be a duplicate
> of the current one. I hope is fixed as well.

The checking that caused this bug was on the 2009-01-10; the other bug was filed 2008-09-26...
(In reply to comment #8)
> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=457269 seems to be a dup.....
As Joshua said, your occurrence might be this one, but original reporter's incident is probably something else entirely. It could be a dup of my bug 472959, which for which I'm moments away from diff-ing a patch of my proposed fix.

Full commentary at: https://bugzilla.mozilla.org/show_bug.cgi?id=457269#c8
There is nothing in litmus for this issue. In fact nowhere do I find explicit mention of regarding junk+account in the account (919) or junk (942) testgroups for FFT (eg testcase 5616)
Flags: in-litmus?
FFT+BFT https://litmus.mozilla.org/show_test.cgi?id=9543
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.