remove pulling of wallet from client.py

RESOLVED FIXED

Status

MailNews Core
Build Config
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Robert Kaiser, Assigned: standard8)

Tracking

Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
Now that bug 433316 has been checked in and we don't need wallet any more, we should remove pulling it from client.py
(Assignee)

Comment 1

9 years ago
Should we remove the wallet directory automatically as well? - I'm thinking mxr, though we could just file a sysadmin bug and ask them to remove the dir.
(Reporter)

Comment 2

9 years ago
I don't think we need to automatically remove the dir, and it's cleaner to just make the buildsystem forget about wallet. It's not that large and therefore not that harmful if it is being kept around but unused somewhere.
(Assignee)

Comment 3

9 years ago
Created attachment 357329 [details] [diff] [review]
The fix

Drops pulling of wallet in client.py
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #357329 - Flags: review?(kairo)
(Reporter)

Comment 4

9 years ago
Comment on attachment 357329 [details] [diff] [review]
The fix

Hmm, could you remove the --skip-cvs option along with this? After your change, it only affects LDAP any more, and that has its own option anyway.
(Assignee)

Comment 5

9 years ago
Created attachment 357664 [details] [diff] [review]
The fix v2

Drops the --skip-cvs option as well.
Attachment #357329 - Attachment is obsolete: true
Attachment #357664 - Flags: review?(kairo)
Attachment #357329 - Flags: review?(kairo)
(Reporter)

Comment 6

9 years ago
Comment on attachment 357664 [details] [diff] [review]
The fix v2

Looks good from code inspection, r=me
Attachment #357664 - Flags: review?(kairo) → review+
(Assignee)

Comment 7

9 years ago
Pushed: http://hg.mozilla.org/comm-central/rev/eddfe639e52f
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Blocks: 474879
Blocks: 232111
Blocks: 312285
Blocks: 201592
Blocks: 423561
You need to log in before you can comment on or make changes to this bug.