Closed Bug 473827 Opened 11 years ago Closed 11 years ago

remove pulling of wallet from client.py

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kairo, Assigned: standard8)

References

Details

Attachments

(1 file, 1 obsolete file)

Now that bug 433316 has been checked in and we don't need wallet any more, we should remove pulling it from client.py
Should we remove the wallet directory automatically as well? - I'm thinking mxr, though we could just file a sysadmin bug and ask them to remove the dir.
I don't think we need to automatically remove the dir, and it's cleaner to just make the buildsystem forget about wallet. It's not that large and therefore not that harmful if it is being kept around but unused somewhere.
Attached patch The fix (obsolete) — Splinter Review
Drops pulling of wallet in client.py
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #357329 - Flags: review?(kairo)
Comment on attachment 357329 [details] [diff] [review]
The fix

Hmm, could you remove the --skip-cvs option along with this? After your change, it only affects LDAP any more, and that has its own option anyway.
Attached patch The fix v2Splinter Review
Drops the --skip-cvs option as well.
Attachment #357329 - Attachment is obsolete: true
Attachment #357664 - Flags: review?(kairo)
Attachment #357329 - Flags: review?(kairo)
Comment on attachment 357664 [details] [diff] [review]
The fix v2

Looks good from code inspection, r=me
Attachment #357664 - Flags: review?(kairo) → review+
Pushed: http://hg.mozilla.org/comm-central/rev/eddfe639e52f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.