Closed
Bug 473827
Opened 15 years ago
Closed 15 years ago
remove pulling of wallet from client.py
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: standard8)
References
Details
Attachments
(1 file, 1 obsolete file)
1.77 KB,
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
Now that bug 433316 has been checked in and we don't need wallet any more, we should remove pulling it from client.py
Assignee | ||
Comment 1•15 years ago
|
||
Should we remove the wallet directory automatically as well? - I'm thinking mxr, though we could just file a sysadmin bug and ask them to remove the dir.
Reporter | ||
Comment 2•15 years ago
|
||
I don't think we need to automatically remove the dir, and it's cleaner to just make the buildsystem forget about wallet. It's not that large and therefore not that harmful if it is being kept around but unused somewhere.
Assignee | ||
Comment 3•15 years ago
|
||
Drops pulling of wallet in client.py
Reporter | ||
Comment 4•15 years ago
|
||
Comment on attachment 357329 [details] [diff] [review] The fix Hmm, could you remove the --skip-cvs option along with this? After your change, it only affects LDAP any more, and that has its own option anyway.
Assignee | ||
Comment 5•15 years ago
|
||
Drops the --skip-cvs option as well.
Attachment #357329 -
Attachment is obsolete: true
Attachment #357664 -
Flags: review?(kairo)
Attachment #357329 -
Flags: review?(kairo)
Reporter | ||
Comment 6•15 years ago
|
||
Comment on attachment 357664 [details] [diff] [review] The fix v2 Looks good from code inspection, r=me
Attachment #357664 -
Flags: review?(kairo) → review+
Assignee | ||
Comment 7•15 years ago
|
||
Pushed: http://hg.mozilla.org/comm-central/rev/eddfe639e52f
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•