There are $ shorthands scattered in with getElementByIds. We should replace all $'s for the sake of consistency.
Created attachment 359478 [details] [diff] [review] patch replacing $'s with getElementById's This patch pretty much just replaces all $'s with getElementById's, except in some cases where it's saved in a var to use in multiple places. Some lines got a bit longer and might need to be broken up.
Assignee: nobody → harthur
Attachment #359478 - Flags: review?(ctalbert)
Comment on attachment 359478 [details] [diff] [review] patch replacing $'s with getElementById's r=ctalbert I'll clean up some of the most egregious long lines left over before check in. Thanks!
Attachment #359478 - Flags: review?(ctalbert) → review+
Checked in: Sending chrome/content/litmus.js Sending chrome/content/notifications.js Sending chrome/content/qa.js Sending chrome/content/qa.xul Sending chrome/content/settings.js Sending chrome/content/tabs/bugzilla.js Sending chrome/content/tabs/chat.xul Sending chrome/content/tabs/qmo.js Sending chrome/content/tabs/selecttests.js Sending chrome/qa.jar Transmitting file data .......... Committed revision 21936.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.