Status

RESOLVED FIXED
10 years ago
4 days ago

People

(Reporter: harth, Assigned: harth)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
There are $ shorthands scattered in with getElementByIds. We should replace all $'s for the sake of consistency.
(Assignee)

Comment 1

10 years ago
Created attachment 359478 [details] [diff] [review]
patch replacing $'s with getElementById's

This patch pretty much just replaces all $'s with getElementById's, except in some cases where it's saved in a var to use in multiple places. Some lines got a bit longer and might need to be broken up.
Assignee: nobody → harthur
Attachment #359478 - Flags: review?(ctalbert)

Comment 2

10 years ago
Comment on attachment 359478 [details] [diff] [review]
patch replacing $'s with getElementById's

r=ctalbert  I'll clean up some of the most egregious long lines left over before check in. Thanks!
Attachment #359478 - Flags: review?(ctalbert) → review+

Comment 3

10 years ago
Checked in:
Sending        chrome/content/litmus.js
Sending        chrome/content/notifications.js
Sending        chrome/content/qa.js
Sending        chrome/content/qa.xul
Sending        chrome/content/settings.js
Sending        chrome/content/tabs/bugzilla.js
Sending        chrome/content/tabs/chat.xul
Sending        chrome/content/tabs/qmo.js
Sending        chrome/content/tabs/selecttests.js
Sending        chrome/qa.jar
Transmitting file data ..........
Committed revision 21936.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

4 days ago
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.