Closed Bug 473907 Opened 15 years ago Closed 15 years ago

Compact folders when it will save over kb crashes - various top of stack - windows: [@ @0x4d8dd6ff], [@ thunderbird.exe@0x96612c] - [@ nsMsgDBFolder::CompactAllOfflineStore] Mac:? linux: [@ thunderbird-bin@0xbefa85]

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
blocker

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: shopik, Assigned: Bienvenu)

References

Details

(4 keywords)

Crash Data

This was working on previous week build
bp-583b7624-33e8-424d-9c8d-0ec232090116
bp-0b2fc303-ddc4-4c3f-92aa-0c0e82090116
bp-457ed900-c81a-499c-a2b8-838812090116
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090109 Shredder/3.0b2pre ID:20090115031919
Also have notice about box is reporting wrong build ID
I can't say for certain, but it looks like it's offline news groups that are causing the crasher.
I'm not using any offline methods for newsgroups. If TB not using this by default.
crash appears to have multiple top of stacks**

bp-583b7624-33e8-424d-9c8d-0ec232090116

@0x4d8dd6ff	
nsMsgDBFolder::CompactAllOfflineStores	nsMsgDBFolder.cpp:1781 
nsMsgDBFolder::AutoCompact	nsMsgDBFolder.cpp:1765
nsMsgNewsFolder::UpdateFolder	nsNewsFolder.cpp:342
NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2424
XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1477 


here's one from vista, with a longer stack
bp-42c7202e-1883-4ed1-961f-b92cb2090115

@0x4d8dd6ff	
nsMsgDBFolder::CompactAllOfflineStores	nsMsgDBFolder.cpp:1781
nsMsgDBFolder::AutoCompact	nsMsgDBFolder.cpp:1765
nsMsgLocalMailFolder::EndMove	nsLocalMailFolder.cpp:2734
nsCopyMessageStreamListener::EndCopy	nsCopyMessageStreamListener.cpp:179
nsCopyMessageStreamListener::OnStopRequest	nsCopyMessageStreamListener.cpp:190
nsImapCacheStreamListener::OnStopRequest	nsImapProtocol.cpp:8071
nsInputStreamPump::OnStateStop	netwerk/base/src/nsInputStreamPump.cpp:576
nsInputStreamPump::OnInputStreamReady	netwerk/base/src/nsInputStreamPump.cpp:401
nsOutputStreamReadyEvent::Run	xpcom/io/nsStreamUtils.cpp:111
nsThread::ProcessNextEvent	xpcom/threads/nsThread.cpp:510
NS_ProcessNextEvent_P	nsThreadUtils.cpp:227 


** searching crash-stats for nsMsgDBFolder::CompactAllOfflineStores it top 10 frames

http://crash-stats.mozilla.com/?do_query=1&product=Thunderbird&version=Thunderbird%3A3.0a3&version=Thunderbird%3A3.0b1&version=Thunderbird%3A3.0b1pre&version=Thunderbird%3A3.0b2pre&query_search=stack&query_type=contains&query=nsMsgDBFolder%3A%3ACompactAllOfflineStores&date=&range_value=1&range_unit=days

yields
Signature	#
@0x4d8dd6ff 	15
thunderbird.exe@0x96612c 	7
thunderbird.exe@0x9675d4 	6
thunderbird.exe@0x9675da 	5
nsCOMPtr_base::assign_from_helper(nsCOMPtr_helper const&, nsID const&) 	2
thunderbird.exe@0x95a9ce 	1
thunderbird.exe@0x9675db 	1
thunderbird-bin@0xbefa85 	1
thunderbird-bin@0xbfdfe4 	1
Summary: Crash when selecting NNTP group → Crash when selecting NNTP group [@ nsMsgDBFolder::CompactAllOfflineStore]
Happen when I mark message as junk in IMAP folder and move to local Junk folder. For example bp-72e0f932-6eb5-45d1-af46-119e02090116 and have same stack - 0x4d8dd6ff
I'm not seeing this, and I use newsgroups heavily.
Possibly having auto-compact set has something to do with it.
Disabling Tools->Options->Advanced->Network & Disk Space->Compact folders when it will save over kb, stop crashing it.
Summary: Crash when selecting NNTP group [@ nsMsgDBFolder::CompactAllOfflineStore] → Compact folders when it will save over kb, will crash [@ nsMsgDBFolder::CompactAllOfflineStore]
It has been suggested that Bug 474091 is related - I'm not sure since I don't use IMAP or Newsgroups - 

TB is failing to start in my case, but is NOT producing a crash report so I can't append.
(In reply to comment #6)
> Disabling Tools->Options->Advanced->Network & Disk Space->Compact folders when
> it will save over kb, stop crashing it.

Followings are "auto compaction" related settings. 
> (a) mail.prompt_purge_threshhold = true
> (b) mail.purge_threshhold        = xxx (KB)
> (c) mail.purge.ask               = false
Will next be also a workaround?
 - Keep true of (a)
 - Reset (c), and restart Tb (AFAIK, mail.purge.ask is read only when restart)
 - NO to dialog for auto-compaction
What will happen if YES is replied to dialog for auto-compaction?
(In reply to comment #8)
> Will next be also a workaround?
>  - Keep true of (a)
>  - Reset (c), and restart Tb (AFAIK, mail.purge.ask is read only when restart)
>  - NO to dialog for auto-compaction
> What will happen if YES is replied to dialog for auto-compaction?
If I select YES it produce crash -  bp-b7c4a45b-8b92-4f48-9541-fdc182090117 if I answer NO don't crash
Problem due to first patch for Bug 466730? (second patch is not landed yet)
> Bug 466730   : file compact folders isn't compacting imap offline stores
> First patch  : "fix checked in" at 2009-01-14 17:57:32 PST, and closed as FIXED
> Second patch : "follow on fix"  at 2009-01-16 11:40 PST, but still under review
Assignee: nobody → bienvenu
Blocks: 466730
Keywords: regression
this is #1 crasher for 3.0b2pre and pretty huge problem for testing.  => sev blocker
Severity: critical → blocker
standard8 thinks patch @ bug 466730 comment 18 will fix this

various top of stack. mostly...
windows: @0x4d8dd6ff, thunderbird.exe@0x96612c

http://crash-stats.mozilla.com/?do_query=1&product=Thunderbird&version=Thunderbird%3A3.0b2pre&query_search=signature&query_type=contains&query=&date=&range_value=4&range_unit=days

except nsMenuItemIconX::OnStopRequest, which is fixed bug 471101
OS: Windows XP → All
Hardware: x86 → All
Summary: Compact folders when it will save over kb, will crash [@ nsMsgDBFolder::CompactAllOfflineStore] → Compact folders when it will save over kb crashes - various top of stack - windows: [@ @0x4d8dd6ff], [@ thunderbird.exe@0x96612c] - [@ nsMsgDBFolder::CompactAllOfflineStore] Mac:? linux: [@ thunderbird-bin@0xbefa85]
(In reply to comment #12)
> standard8 thinks patch @ bug 466730 comment 18 will fix this

That patch fixed it for me.
The patch in bug 466730 has now been pushed. This should be fixed in tomorrow's nightlies.
file>compact folders doesn't crash with the nightly that picked up bug 466730's patch  Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20090118 Shredder/3.0b2pre
=> FIXED  (Nikolay can verify)

Thanks Mark
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Crash Signature: [@ @0x4d8dd6ff] [@ thunderbird.exe@0x96612c] [@ nsMsgDBFolder::CompactAllOfflineStore] [@ thunderbird-bin@0xbefa85]
You need to log in before you can comment on or make changes to this bug.