Create separate theme folders for hildon(maemo) and wince

VERIFIED FIXED

Status

Fennec Graveyard
General
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

Details

Attachments

(1 attachment, 2 obsolete attachments)

Created attachment 357390 [details] [diff] [review]
patch

Fennec needs to support separate themes (skins) for building Maemo and Windows Mobile.

This patch separates the chrome/skin folder into two theme folders:
* create theme/hildon and theme/wince folders
* update makefiles
* moves firstrun files out of the chrome/content folder and into the theme folders
* defaults to the hildon theme (so desktop builds will also use it)
* added a new platform.css file for the low-level theme changes (pulled code from browser.css)

There are a lot of deletes/adds in the patch
Attachment #357390 - Flags: review?(gavin.sharp)
Created attachment 357828 [details] [diff] [review]
patch 2 - used hg to move stuff around

this patch should be the same as the first patch, but I used hg rename to move all of the skin files into the themes/hildon folder. I still had to add them all again in the wince folder.

It might be a tad easier to review
Assignee: nobody → mark.finkle
Attachment #357390 - Attachment is obsolete: true
Attachment #357828 - Flags: review?(gavin.sharp)
Attachment #357390 - Flags: review?(gavin.sharp)
Comment on attachment 357828 [details] [diff] [review]
patch 2 - used hg to move stuff around

r=me, but you should use |hg cp| rather than manually copying/hg adding the wince files.
Attachment #357828 - Flags: review?(gavin.sharp) → review+
Created attachment 358038 [details] [diff] [review]
patch 3 - used | hg cp | to copy in the wince folder

final patch used for checkin
Attachment #357828 - Attachment is obsolete: true
http://hg.mozilla.org/mobile-browser/rev/ac352ddf763b
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
verified fixed in 20091001 1.9.2 b4 on my n810 and via mxr.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.